Uh oh!
There was an error while loading. Please reload this page.
Update README for ESLint config - #7451
Merged
Merged
Conversation
mrmckeb
requested review from
bugzpodder, ianschmitz, iansu and petetnt
as code ownersJuly 30, 2019 11:45
ianschmitz
approved these changes
Jul 30, 2019
miraage
commented
Jul 31, 2019
@mrmckeb@ianschmitz@Timer what do you think if https://www.npmjs.com/package/install-peerdeps was mentioned instead of manually hardcoding peerdeps versions? |
mrmckeb
commented
Aug 1, 2019
ContributorAuthor
Hi @miraage, I think - ideally - these should be dependencies. I know that the ESLint team are working towards this, and that would be great. In the interim, we could add that to the docs... with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the docs as per comment from @Timer.
This was missed on #7415.