Uh oh!
There was an error while loading. Please reload this page.
Don't block static files in robots.txt - #7508
Merged
Merged
Conversation
iansu
requested review from
bugzpodder, ianschmitz, mrmckeb and petetnt
as code ownersAugust 10, 2019 23:51
iansu
commented
Aug 10, 2019
ContributorAuthor
I know I also have to update the TypeScript template. I was trying to do this through GitHub. |
bugzpodder
approved these changes
Aug 10, 2019
ianschmitz
approved these changes
Aug 11, 2019
ianschmitz
left a comment
Contributor
There was a problem hiding this comment.
Should we ditch the file completely or do you think it still has value?
iansu
commented
Aug 11, 2019
ContributorAuthor
We should probably release 3.1.1 with this fix. |
iansu
commented
Aug 11, 2019
ContributorAuthor
@ianschmitz I believe it's necessary to get the 100% score on Lighthouse. |
mrmckeb
commented
Aug 11, 2019
Contributor
Yes, let's leave the file - we as we want to retain that 100%. It's a good win. |
petetnt
approved these changes
Aug 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in #7482