Skip to content

Bump version of @typescript-eslint/* - #7540

Merged
ianschmitz merged 3 commits into
react:masterfrom
steppegras:bump-version-of-typescript-eslint
Sep 11, 2019
Merged

Bump version of @typescript-eslint/*#7540
ianschmitz merged 3 commits into
react:masterfrom
steppegras:bump-version-of-typescript-eslint

Conversation

@pierreneter

@pierreneterpierreneter commented Aug 15, 2019•
edited by ianschmitz
Loading

Copy link
Copy Markdown
Contributor

This PR will close#7529

@pierreneter

pierreneter commented Aug 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Can resolve eslint/eslint#12093 from this PR.

@pierreneterpierreneter mentioned this pull request Aug 18, 2019
Closed
@SamChou19815SamChou19815 mentioned this pull request Aug 28, 2019
Merged
4 tasks
@Svish

Svish commented Sep 3, 2019

Copy link
Copy Markdown

... any progress on getting this fix released? 🤔

@CodingDive

CodingDive commented Sep 3, 2019

Copy link
Copy Markdown

I had to upgrade to Eslint v6 and some packages were already using v2 of @typescript-eslint. Since react-scripts is still on the old version, I'm getting one eslint error per file saying Definition for rule '@typescript-eslint/no-angle-bracket-type-assertion' was not found.

Hoping for a quick release as Eslint is unusable for me for the time being 🙏

@jonathas

jonathas commented Sep 3, 2019

Copy link
Copy Markdown

@ReasonableDeveloper Same case for me

@vcanales

vcanales commented Sep 5, 2019

Copy link
Copy Markdown

+1, necessary to fix issues coming from this: typescript-eslint/typescript-eslint#863

@neilbryson

neilbryson commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

@CodingDive : You could add "@typescript-eslint/no-angle-bracket-type-assertion": "off" for the time being

@pierreneter

pierreneter commented Sep 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz please review.

ianschmitz
ianschmitz suggested changes Sep 9, 2019
View reviewed changes
Comment threadpackages/eslint-config-react-app/index.js Outdated
Comment threadpackages/react-scripts/package.json Outdated
@ianschmitzianschmitz self-assigned this Sep 9, 2019
@ianschmitzianschmitz added this to the 3.1.2 milestone Sep 9, 2019
@Siyfion

Siyfion commented Sep 10, 2019•
edited
Loading

Copy link
Copy Markdown

This looks great @pierreneter! I've been keeping users at TS 3.5.3 due to typescript-estree not supporting the later versions officially. It'll be good to let people upgrade and use the new features without worry! 😄

@ianschmitz
ianschmitz merged commit b3f8ef2 into react:masterSep 11, 2019
@ianschmitz

ianschmitz commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

Thanks! 😃

@locklockBot locked and limited conversation to collaborators Sep 16, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bugzpodderbugzpodderAwaiting requested review from bugzpodder
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt
3 more reviewers
@SamChou19815SamChou19815SamChou19815 left review comments
@ianschmitzianschmitzianschmitz requested changes
@rogerclotetrogerclotetrogerclotet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ianschmitzianschmitz

Labels

CLA Signedtag: underlying tools

Projects

None yet

Milestone

3.1.2

Development

Successfully merging this pull request may close these issues.

Upgrade typescript-eslint to v2

11 participants

@pierreneter@Svish@CodingDive@jonathas@vcanales@neilbryson@Siyfion@ianschmitz@rogerclotet@SamChou19815@facebook-github-bot