Skip to content

Update running-tests.md - #7659

Merged
iansu merged 1 commit into
react:masterfrom
weyert:patch-1
Sep 9, 2019
Merged

Update running-tests.md#7659
iansu merged 1 commit into
react:masterfrom
weyert:patch-1

Conversation

@weyert

@weyertweyert commented Sep 7, 2019

Copy link
Copy Markdown
Contributor

Fixed the unit test in the @testing-library bit of the page as Welcome to React is not being used in the App.js.

Made the change in newly created CRA app and ran the tests in Gitlab CI:

$ react-scripts test
PASS src/App.test.js
✓ renders welcome message (82ms)

@weyert
Update running-tests.md
c1afc66
Fixed the unit test in the @testing-library bit of the page as Welcome to React is not being used in the `App.js`
@iansuiansu added this to the 3.1.2 milestone Sep 9, 2019
@iansu
iansu merged commit 0f9e350 into react:masterSep 9, 2019
@iansu

iansu commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Thanks!

VasilyShelkov pushed a commit to VasilyShelkov/create-react-extension that referenced this pull request Sep 9, 2019
@weyert@VasilyShelkov
Update running-tests.md (react#7659)
bf170f2
@locklockBot locked and limited conversation to collaborators Sep 14, 2019
@weyert
weyert deleted the patch-1 branch November 24, 2019 19:03
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlamamyrlamAwaiting requested review from amyrlam
@iansuiansuAwaiting requested review from iansu

Assignees

No one assigned

Labels

CLA Signedtag: documentation

Projects

None yet

Milestone

3.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@weyert@iansu@facebook-github-bot