Skip to content

Remove 'shortcut' link type before 'icon' - #7707

Merged
iansu merged 1 commit into
react:masterfrom
lewislbr:master
Sep 20, 2019
Merged

Remove 'shortcut' link type before 'icon'#7707
iansu merged 1 commit into
react:masterfrom
lewislbr:master

Conversation

@lewislbr

@lewislbrlewislbr commented Sep 20, 2019

Copy link
Copy Markdown

According to this MDN page,

The shortcut link type is often seen before icon, but this link type is non-conforming, ignored and web authors must not use it anymore.

So I removed it from all files except a Changelog file, which I assume is inmutable.

@iansuiansu added this to the 3.1.3 milestone Sep 20, 2019
@iansu
iansu merged commit 05f7924 into react:masterSep 20, 2019
@iansu

iansu commented Sep 20, 2019

Copy link
Copy Markdown
Contributor

Thanks!

@locklockBot locked and limited conversation to collaborators Sep 25, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlamamyrlamAwaiting requested review from amyrlam
@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt

Assignees

No one assigned

Labels

CLA Signedtag: internal

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@lewislbr@iansu@facebook-github-bot