Uh oh!
There was an error while loading. Please reload this page.
Typo fix in webpack.config.dev.js comments - #777
Conversation
ghost
commented
Sep 27, 2016
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
gaearon
commented
Sep 27, 2016
Can you please fix this in prod config as well? Thank you! |
ghost
commented
Sep 27, 2016
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
sebastiandedeyne
commented
Sep 27, 2016
Done! |
gaearon
commented
Sep 27, 2016
Would it be too much to ask you to look through all other files and hunt for typos? I'm pretty sure I made a few more but I can't remember where. No worries if it's too much, just let me know. |
sebastiandedeyne
commented
Sep 27, 2016
Sure :) I'll try to go through it tomorrow! On Tuesday, 27 September 2016, Dan Abramov notifications@github.com wrote:
|
gaearon
commented
Sep 30, 2016
Going to get this in for now but I’d still appreciate a complete review. 😄 |
…react-app # By Dan Abramov (5) and others # Via Dan Abramov * 'master' of https://github.com/facebookincubator/create-react-app: docs(readme): peer dependencies applied (react#818) Fix typos on ISSUE_TEMPLATE.md (react#817) Add explicit linebreaks (react#813) Fix typo (react#810) Fix some typos (react#809) Beaufity output of eject.js script (react#769) Define process.env as object (react#807) Typo fix in webpack.config.dev.js comments (react#777) Add Netlify to deploy instructions Fix usage example to match react-dev-utils@0.2.x API Relaxed eslint rule no-unused-expressions (react#724) Fix the doc Publish Add 0.6.1 changelog Moved Babel and ESLint config to package.json after ejecting (react#773) Conflicts: packages/react-scripts/package.json
* Typo fix in webpack.config.dev.js comments * Typo fix in webpack.config.prod.js comments
…react-app # By Dan Abramov (5) and others # Via Dan Abramov * 'master' of https://github.com/facebookincubator/create-react-app: docs(readme): peer dependencies applied (react#818) Fix typos on ISSUE_TEMPLATE.md (react#817) Add explicit linebreaks (react#813) Fix typo (react#810) Fix some typos (react#809) Beaufity output of eject.js script (react#769) Define process.env as object (react#807) Typo fix in webpack.config.dev.js comments (react#777) Add Netlify to deploy instructions Fix usage example to match react-dev-utils@0.2.x API Relaxed eslint rule no-unused-expressions (react#724) Fix the doc Publish Add 0.6.1 changelog Moved Babel and ESLint config to package.json after ejecting (react#773) Conflicts: packages/react-scripts/package.json
No description provided.