Uh oh!
There was an error while loading. Please reload this page.
Add support for pnpm package manager - #7791
Conversation
facebook-github-bot
commented
Oct 7, 2019
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Oct 7, 2019
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
mrmckeb
commented
Oct 9, 2019
Hi @macjabeth, thanks for spending the time on this. In future, I'd recommend that you raise an issue first just to ensure this work isn't being tackled by someone else - we don't ever want people to waste time... We're about to roll out a new feature in the coming weeks, and this PR would conflict with that... if you're OK with it, could we fix conflicts and merge this in after PR that is merged? |
macjabeth
commented
Oct 9, 2019
@mrmckeb Of course! Sorry for not raising an issue first... Would be happy waiting until then and resolving any conflicts. |
mrmckeb
commented
Oct 10, 2019
If you can subscribe to #7716, we can resume this PR as soon as that's merged. I hope next week, as I'll spend Monday finishing it off. |
arzga
commented
Mar 11, 2020
Would love to see this improvement to make it to the master ;) |
ZachHaber
commented
Apr 14, 2020
Is there anything I can do to help get this added? |
I guess we'd better re-apply changes made by @macjabeth based on the current master branch? In the meantime, I created a script in my PATH named npm, which call |
alex-shamshurin
commented
Aug 15, 2020
Is there any progress and chances to merge it? |
adelarsq
commented
Sep 23, 2020
Any update on this? |
nyn3x
commented
Feb 4, 2021
Is there any update on this? I would very much like this feature to be in CRA ... |
DylanCulfogienis
commented
May 10, 2021
Any news on this? |
beenotung
commented
May 21, 2021
ashishbinu
commented
Aug 30, 2021
Hope it gets implemented soon |
ruifortes
commented
Sep 29, 2021
Hey!! Facebook!! Could you?!? Hum. hum?? |
Philzen
commented
Feb 2, 2022
Any update on this? |
karlhorky
commented
Apr 14, 2023
For those who want to go down with the ship ( pnpm create @upleveled/react-app my-app |
beenotung
commented
Apr 15, 2023
If you just want to create a typescript react app, instead of a generic creator with multiple template options. You can run: npm init react-ts-templateOr npx create-react-ts-templateIt will create the project for you (without installing the dependencies) You can then cd into the project directory and install with any package manager, e.g. cd my-app
pnpm i |
CoolPlayLin
commented
Jan 1, 2024
Hello @macjabeth |
Hello! I was researching if CRA had any support for the pnpm package manager. I came across issue #2809 and - per the last comment - decided to try and tackle this implementation myself.
This is my initial pull request, and I know it still needs some work because I tested it myself and after there are some issues still. I'm hoping by creating this PR, it'll get a discussion going on how to properly implement this.
Thank you for considering this feature!