Skip to content

Upgrade outdated packages - #7814

Merged
andriijas merged 1 commit into
react:masterfrom
andriijas:bump
Oct 25, 2019
Merged

Upgrade outdated packages#7814
andriijas merged 1 commit into
react:masterfrom
andriijas:bump

Conversation

@andriijas

@andriijasandriijas commented Oct 12, 2019

Copy link
Copy Markdown
Contributor
  • Bumping packages with minor/backwards compatible releases.
  • Went through each package with major release and verified checklogs - most just drops support for node versions prior 8.9

Some packages with major releases needs to be verified in separate PR in react-dev-tools

@ianschmitz

Copy link
Copy Markdown
Contributor

Looks like you're running into the same issue i was with a newer version of webpack-dev-server: #7473 (comment)

@iansu@mrmckeb we talked about unpinning some packages in next release. Are we alright unpinning in this PR?

@ianschmitzianschmitz self-assigned this Oct 14, 2019
@andriijasandriijas changed the title Bump minorsUpgrade outdated packagesOct 15, 2019
@andriijas

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz Yeah and I forgot to update the PR description. Let me know about the pinning and i adjust

@iansu

Copy link
Copy Markdown
Contributor

I think our plan was to try out unpinning everything in a beta. Which will likely be 4.0 at this point.

@andriijas

Copy link
Copy Markdown
ContributorAuthor

@iansu i updated the PR holding back webpack-dev-server for now and tests are passing. I can see if i can pinpoint the version in separate PR.

@ianschmitzianschmitz added this to the 3.2.1 milestone Oct 16, 2019

@ianschmitzianschmitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you go through the other packages and make sure we're synced? For example babel-preset-react-app needs to be bumped as well.

@andriijas

Copy link
Copy Markdown
ContributorAuthor

@iansu Done. Going to check why the docs deploy test failed.

There are more packages to upgrade but they contain incompatible changes so let's do that in separate PR

@iansuiansu modified the milestones: 3.2.1, 3.3Oct 23, 2019
@andriijas
andriijasforce-pushed the bump branch 5 times, most recently from 1c4a80e to 9593b47CompareOctober 24, 2019 13:04
@andriijas

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz rebased and I went ahead and checked through each webpack-dev-server version. Unfortunately the issue discussed in the linked issue above was introduced already with 3.3.0 so we need to stick with 3.2.1 for now unless we have another way around

@andriijas
andriijas merged commit 324428f into react:masterOct 25, 2019
@andriijas
andriijas deleted the bump branch October 25, 2019 08:36
@locklockBot locked and limited conversation to collaborators Oct 30, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@andriijas@ianschmitz@iansu@facebook-github-bot