Skip to content

Add numeric separator support - #7817

Merged
ianschmitz merged 9 commits into
react:masterfrom
tharun208:master
Oct 30, 2019
Merged

Add numeric separator support#7817
ianschmitz merged 9 commits into
react:masterfrom
tharun208:master

Conversation

@tharun208

@tharun208tharun208 commented Oct 13, 2019

Copy link
Copy Markdown
Contributor

Closes#7329.

This PR has added the support for numeric supporters using babel plugin.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tharun208tharun208 changed the title This fixes the issue #7329This fixes the issue #7329 ( Added numeric support )Oct 13, 2019
Comment threadpackages/babel-preset-react-app/create.js Outdated
Comment threadpackages/babel-preset-react-app/package.json Outdated
Comment threadpackages/babel-preset-react-app/package.json Outdated
@ianschmitzianschmitz changed the title This fixes the issue #7329 ( Added numeric support )Add numeric separator supportOct 16, 2019
@tharun208

Copy link
Copy Markdown
ContributorAuthor

Hi @ianschmitz, thanks for reviewing and I fixed the changes, can you check?

@ianschmitzianschmitz added this to the 3.3 milestone Oct 17, 2019
@tharun208

Copy link
Copy Markdown
ContributorAuthor

Hi @ianschmitz, Is there any bug in your CI/CD script, it is running perfectly for some jobs and rest, it is suggesting me to add @babel/plugin-syntax-jsx.That's why, I added the above in the package.json.

@ianschmitz

Copy link
Copy Markdown
Contributor

I'll take a look after the next run

@tharun208

tharun208 commented Oct 17, 2019

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz, Is it good to go? or we can inspect the ci/cd script by giving a test run.

@ianschmitz

Copy link
Copy Markdown
Contributor

@tharun208 i didn't see any failures in CI. Did i miss something?

@ianschmitzianschmitz self-assigned this Oct 18, 2019
@tharun208

Copy link
Copy Markdown
ContributorAuthor

No @ianschmitz, it is good to go then

@tharun208

Copy link
Copy Markdown
ContributorAuthor

Hi @ianschmitz, Do I need to do anything ? or is it good to get merged?

@ianschmitz
ianschmitz merged commit b4fe788 into react:masterOct 30, 2019
@ianschmitz

Copy link
Copy Markdown
Contributor

Nope. All good. Thanks @tharun208!

@locklockBot locked and limited conversation to collaborators Nov 4, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript: Support numeric separators

4 participants

@tharun208@facebook-github-bot@ianschmitz@iansu