Skip to content

Add Alex to lint documentation - #7852

Merged
iansu merged 4 commits into
react:masterfrom
iansu:alexjs
Oct 24, 2019
Merged

Add Alex to lint documentation#7852
iansu merged 4 commits into
react:masterfrom
iansu:alexjs

Conversation

@iansu

@iansuiansu commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

This sets up Alex to lint our docs. We're also going to have to update some of the docs so they pass the linter and possibly deactivate some of the rules.

I also thought this would be a good time to try out GitHub Actions but it seems like it's not enabled on Facebook's account or maybe just this repo? 😂

cc @JoelMarcey

@andriijasandriijas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet addition!

@endiliey

Copy link
Copy Markdown
Contributor

I also thought this would be a good time to try out GitHub Actions but it seems like it's not enabled on Facebook's account or maybe just this repo?

I think only this repo. We are able to setup GH Actions on Docusaurus. cc @JoelMarcey to enable it for CRA 😉

@JoelMarcey

Copy link
Copy Markdown
Contributor

It looks to be enabled already for this repo 🤔

Screenshot 2019-10-21 18 52 00

@iansu

Copy link
Copy Markdown
ContributorAuthor

It's running on my fork so this config appears to be correct. Maybe it's not running in the PR because the config isn't present in this repo on master? I'm going to try making and merging another PR that just runs ESLint in an action.

@iansu

Copy link
Copy Markdown
ContributorAuthor

Okay, that actually worked in my other branch. I think this makes sense. GitHub won't run actions that are defined in PRs from a fork. Otherwise people could basically DOS your CI I guess? Or do other bad things.

Comment thread.alexrc
"colors",
"conservative",
"crashes",
"executed",

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the software industry uses a lot of aggressive words to describe things.

@iansuiansu added this to the 3.3 milestone Oct 24, 2019
@iansu
iansu merged commit 1d03579 into react:masterOct 24, 2019
@iansu
iansu deleted the alexjs branch October 24, 2019 18:14
@locklockBot locked and limited conversation to collaborators Oct 29, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@iansu@endiliey@JoelMarcey@andriijas@facebook-github-bot