Uh oh!
There was an error while loading. Please reload this page.
Mark TypeScript as an optional peer dependency for react-scripts - #7860
Conversation
facebook-github-bot
commented
Oct 21, 2019
Hi dstaley! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
iansu
commented
Oct 21, 2019
@dstaley Awesome! I suppose we'll have to publish this change to get the tests passing in Yarn v2? I can merge this right away but it might not be published for a week or two as we're currently working on the next release. |
dstaley
commented
Oct 21, 2019
@iansu yeah, we'd need |
facebook-github-bot
commented
Oct 21, 2019
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ianschmitz
commented
Oct 31, 2019
Thanks @dstaley! |
This PR adds TypeScript as an optional peer dependency for
react-scripts. This modification is necessary to getreact-scriptsworking with Yarn v2, and will enable the TypeScript template forcreate-react-appto work with Yarn v2.This PR uses the
peerDependenciesMetakey, which signifies to Yarn thattypescriptis an optional dependency. npm will support the key in the future, in which case"typescript": "*"can be added topeerDependencies. Until that change is made, simply havingpeerDependenciesMetawill be enough for Yarn, and won't adversely impact users of npm.Other relevant issues: yarnpkg/berry/pull/475
/cc @iansu