Uh oh!
There was an error while loading. Please reload this page.
Automatically remove testing code when ejecting. - #787
Conversation
ghost
commented
Sep 28, 2016
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
ghost
commented
Sep 28, 2016
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
bnjmnt4n
commented
Sep 30, 2016
Just realised this doesn't work, sorry for the wrong pull request 😭 |
gaearon
commented
Sep 30, 2016
Yea, unfortunately this breaks the end to end test because it is supposed to test the code after ejecting 😄 . I’d appreciate if you could look into changing our end-to-end test to kill the process when the successful compilation output is printed. |
No description provided.