Uh oh!
There was an error while loading. Please reload this page.
Set resetMocks to true by default in jest config - #7899
Merged
Conversation
alexkrolick
requested review from
ianschmitz, iansu, mrmckeb and petetnt
as code ownersOctober 29, 2019 20:18
alexkrolick
commented
Oct 29, 2019
ContributorAuthor
I think this would be a breaking change |
kentcdodds
commented
Oct 29, 2019
Contributor
I agree with this PR. But I wouldn't hold up #7881 for this. You can definitely use React Testing Library without this enabled. |
ianschmitz
commented
Oct 29, 2019
Contributor
Agreed. I have always set this to I'm for it, let's see what the other maintainers think. |
alexkrolick
commented
May 4, 2020
ContributorAuthor
I'm still all for this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resetMocks: trueto the template in createJestConfigSee also jestjs/jest#9047