Skip to content

Fix cli bin path - #8

Merged
vjeux merged 1 commit into
react:masterfrom
keyz:cli-bin-path
Jul 17, 2016
Merged

Fix cli bin path#8
vjeux merged 1 commit into
react:masterfrom
keyz:cli-bin-path

Conversation

@keyz

@keyzkeyz commented Jul 17, 2016

Copy link
Copy Markdown
Contributor

The current setup doesn't work with nvm: the create-react-app file doesn't get added to npm's global .bin folder. Adding a ./ prefix fixed this.

https://docs.npmjs.com/files/package.json#bin

@ghostghost added the CLA Signed label Jul 17, 2016
@vjeux
vjeux merged commit b1cf65e into react:masterJul 17, 2016
@keyz

keyz commented Jul 17, 2016

Copy link
Copy Markdown
ContributorAuthor

@vjeux could/did you publish a new version? :)

@vjeux

Copy link
Copy Markdown
Contributor

This is not on npm yet. What new version do you want me to release?

@keyz

keyz commented Jul 17, 2016

Copy link
Copy Markdown
ContributorAuthor

@gaearon

Copy link
Copy Markdown
Contributor

That's a placeholder package for now. It just has a name but no code. We'll keep it that way until the official release. For now "Contributing" flow in README is the only way to test this thing!

@gaearon

Copy link
Copy Markdown
Contributor

(I guess npm link could also work)

@keyz

keyz commented Jul 17, 2016

Copy link
Copy Markdown
ContributorAuthor

@gaearon lol so that's why i got no bin after running npm install -g create-react-app! Should have asked you before haha. but this PR should be fine anyway (I published my own fork on npm and tested it). :)

@gaearon

Copy link
Copy Markdown
Contributor

Please be careful publishing forks, somebody might watch your account and then it'll be all over Twitter ;-)

@keyz

keyz commented Jul 17, 2016

Copy link
Copy Markdown
ContributorAuthor

Yeah I unpublished it already after testing :)

vjeux pushed a commit that referenced this pull request Jul 18, 2016
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@keyz@vjeux@gaearon