Skip to content

Add package-runner note to readme - #8132

Merged
iansu merged 2 commits into
react:masterfrom
JeromeDeLeon:patch-1
Dec 15, 2019
Merged

Add package-runner note to readme#8132
iansu merged 2 commits into
react:masterfrom
JeromeDeLeon:patch-1

Conversation

@JeromeDeLeon

@JeromeDeLeonJeromeDeLeon commented Dec 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@facebook-github-bot

facebook-github-bot commented Dec 10, 2019

Copy link
Copy Markdown

Hi JeromeDeLeon! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Dec 10, 2019

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

iansu
iansu suggested changes Dec 10, 2019
View reviewed changes
Comment threadREADME.md Outdated
```

_`yarn create` is available in Yarn 0.25+_
_`yarn create <initializer>` is available in Yarn 0.25+_

@iansuiansuDec 10, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to the yarn create docs here?

@JeromeDeLeonJeromeDeLeonDec 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@iansuiansu added this to the 3.3.1 milestone Dec 15, 2019
@iansu
iansu merged commit f314855 into react:masterDec 15, 2019
@iansu

iansu commented Dec 15, 2019

Copy link
Copy Markdown
Contributor

Thanks!

@JeromeDeLeon
JeromeDeLeon deleted the patch-1 branch December 16, 2019 03:15
@locklockBot locked and limited conversation to collaborators Dec 21, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@iansuiansuiansu requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: documentation

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@JeromeDeLeon@facebook-github-bot@iansu