Skip to content

Add current version and bin location to --info output - #8168

Merged
andriijas merged 1 commit into
react:masterfrom
heyimalex:output-version-info
Dec 13, 2019
Merged

Add current version and bin location to --info output#8168
andriijas merged 1 commit into
react:masterfrom
heyimalex:output-version-info

Conversation

@heyimalex

Copy link
Copy Markdown
Contributor

Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules.

New output looks like this:

Environment Info:
+ current version of create-react-app: 3.3.0+ running from C:\Users\alex\AppData\Local\Yarn\Data\global\node_modules\create-react-app+
System:
OS: Windows 10 10.0.18362
CPU: (8) x64 Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
Binaries:
Node: 12.13.1 - C:\Program Files\nodejs\node.EXE
Yarn: 1.19.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.10.1 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 44.18362.449.0
Internet Explorer: 11.0.18362.1
npmPackages:
react: Not Found
react-dom: Not Found
react-scripts: Not Found
npmGlobalPackages:
create-react-app: Not Found

Make the --info subcommand outuput the current version information and the location of the file being run. Our issue template tells users to provide the output of --info, so having the current version is incredibly helpful, especially since it doesn't necessarily match the globally installed version that envinfo outputs. Knowing the location helps us determine whether the running bin is globally installed or in the local node_modules.
@andriijas
andriijas merged commit ebcffda into react:masterDec 13, 2019
@andriijas

Copy link
Copy Markdown
Contributor

Good addition!

@locklockBot locked and limited conversation to collaborators Dec 18, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@heyimalex@andriijas@ianschmitz@facebook-github-bot