Skip to content

Update setting-up-your-editor.md - #8247

Merged
ianschmitz merged 1 commit into
react:masterfrom
eip1599:patch-1
Jan 30, 2020
Merged

Update setting-up-your-editor.md#8247
ianschmitz merged 1 commit into
react:masterfrom
eip1599:patch-1

Conversation

@eip1599

Copy link
Copy Markdown
Contributor

Auto Fix is enabled by default. Use the single string form.

Warning is shown in .vscode/settings.json due to changes in vscode-eslint.

Screen Shot 2019-12-27 at 8 02 21 PM

As autoFix is set to default, object format in eslint.validate is now deprecated.

Check this commit. vscode-eslint#7b5c40536131aa94eccd8a175e37104f5b785071

`Auto Fix is enabled by default. Use the single string form.` warning is shown in `.vscode/settings.json` due to changes in vscode-eslint. As autoFix is set to default, object format in `eslint.validate` is deprecated.
microsoft/vscode-eslint@7b5c405#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R223
@facebook-github-bot

Copy link
Copy Markdown

Hi dev-xu! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale

staleBot commented Jan 27, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Jan 27, 2020
@eip1599

Copy link
Copy Markdown
ContributorAuthor

@iansu , @amyrlam . Could you confirm this simple change?

@stalestaleBot removed the stale label Jan 27, 2020
@ianschmitzianschmitz added this to the 3.3.1 milestone Jan 30, 2020
@ianschmitz
ianschmitz merged commit ca9c61e into react:masterJan 30, 2020
@ianschmitz

Copy link
Copy Markdown
Contributor

Thanks!

@locklockBot locked and limited conversation to collaborators Feb 5, 2020
@eip1599
eip1599 deleted the patch-1 branch April 18, 2020 16:38
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@eip1599@facebook-github-bot@ianschmitz@amyrlam