Skip to content

Add "Disallow:" to robots.txt - #8255

Merged
ianschmitz merged 1 commit into
react:masterfrom
tomoyaf:patch-1
Jan 30, 2020
Merged

Add "Disallow:" to robots.txt#8255
ianschmitz merged 1 commit into
react:masterfrom
tomoyaf:patch-1

Conversation

@tomoyaf

@tomoyaftomoyaf commented Dec 29, 2019

Copy link
Copy Markdown
Contributor

The default robots.txt is incorrect, so I set it valid.

@tomoyaf
Fix robots.txt
03c1e0b
Fix robots.txt
@facebook-github-bot

facebook-github-bot commented Dec 29, 2019

Copy link
Copy Markdown

Hi tomoyaf! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Dec 29, 2019

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tomoyaftomoyaf changed the title Fix robots.txtAdd "Disallow:" to /public/robots.txtJan 1, 2020
@ianschmitzianschmitz added this to the 3.3.1 milestone Jan 30, 2020
@ianschmitzianschmitz changed the title Add "Disallow:" to /public/robots.txtAdd "Disallow:" to robots.txtJan 30, 2020
@ianschmitz
ianschmitz merged commit ed162a3 into react:masterJan 30, 2020
@ianschmitz

ianschmitz commented Jan 30, 2020

Copy link
Copy Markdown
Contributor

Thanks!

@Kamahl19

Kamahl19 commented Jan 31, 2020

Copy link
Copy Markdown
Contributor

What about the TS template? :) https://github.com/facebook/create-react-app/blob/master/packages/cra-template-typescript/template/public/robots.txt

@Kamahl19Kamahl19 mentioned this pull request Jan 31, 2020
Merged
@tomoyaf
tomoyaf deleted the patch-1 branch January 31, 2020 12:32
@locklockBot locked and limited conversation to collaborators Feb 5, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt

Assignees

No one assigned

Labels

CLA Signedtag: bug fix

Projects

None yet

Milestone

3.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@tomoyaf@facebook-github-bot@ianschmitz@Kamahl19