Skip to content

Handle service worker error in Firefox - #8272

Merged
andriijas merged 2 commits into
react:masterfrom
rosinghal:patch-1
Jan 31, 2020
Merged

Handle service worker error in Firefox#8272
andriijas merged 2 commits into
react:masterfrom
rosinghal:patch-1

Conversation

@rosinghal

@rosinghalrosinghal commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

@facebook-github-bot

facebook-github-bot commented Jan 3, 2020

Copy link
Copy Markdown

Hi rosinghal! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Jan 3, 2020

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

andriijas
andriijas suggested changes Jan 31, 2020
View reviewed changes

@andriijasandriijas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please also update cra-template/template/src/serviceWorker.js

Thanks

@rosinghal

rosinghal commented Jan 31, 2020

Copy link
Copy Markdown
ContributorAuthor

@andriijas done

@andriijasandriijas added this to the 3.4 milestone Jan 31, 2020
@andriijas
andriijas merged commit 3190e4f into react:masterJan 31, 2020
@andriijas

andriijas commented Jan 31, 2020

Copy link
Copy Markdown
Contributor

Thanks!

@rosinghal
rosinghal deleted the patch-1 branch January 31, 2020 16:09
@locklockBot locked and limited conversation to collaborators Feb 5, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt
2 more reviewers
@andriijasandriijasandriijas requested changes
@awiboxawiboxawibox approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: bug fixtag: enhancement

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@rosinghal@facebook-github-bot@andriijas@awibox