Skip to content

Use native ESLint behaviour when extending - #8276

Merged
ianschmitz merged 1 commit into
masterfrom
feature/eslint-fixes
Mar 1, 2020
Merged

Use native ESLint behaviour when extending#8276
ianschmitz merged 1 commit into
masterfrom
feature/eslint-fixes

Conversation

@mrmckeb

Copy link
Copy Markdown
Contributor

Resolves#7776.

This PR updates the docs to meet the current implementation, and falls back to native ESLint extends behaviour when the user sets EXTEND_ESLINT.

@mrmckebmrmckeb self-assigned this Jan 3, 2020
@mrmckebmrmckeb added this to the 3.4 milestone Jan 3, 2020
@iansuiansu mentioned this pull request Jan 8, 2020
21 tasks
@mrmckebmrmckeb modified the milestones: 3.4, 3.3.1Jan 8, 2020
@ianschmitzianschmitz modified the milestones: 3.3.1, 3.4Jan 31, 2020
@iansuiansu modified the milestones: 3.4, 3.5Feb 14, 2020
@ianschmitzianschmitz modified the milestones: 3.5, 3.4.1Feb 19, 2020
@ianschmitzianschmitz reopened this Feb 19, 2020
@hatched-tom

Copy link
Copy Markdown

Just been looking through the PR - wondering if there is any reason why it's still waiting to be merged? (not familiar with the process 😅 )

@mrmckeb

Copy link
Copy Markdown
ContributorAuthor

Good question, I think this was missed. @ianschmitz shall we merge this in and get it out with the next release?

@ianschmitz
ianschmitz merged commit 4d26208 into masterMar 1, 2020
@locklockBot locked and limited conversation to collaborators Mar 10, 2020
@ianschmitz
ianschmitz deleted the feature/eslint-fixes branch March 20, 2020 23:48
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extending ESLint is not supporting overrides

6 participants

@mrmckeb@hatched-tom@ianschmitz@iansu@amyrlam@facebook-github-bot