Uh oh!
There was an error while loading. Please reload this page.
Fixes unchecked access to 'deploy' script on build - #8292
Merged
Conversation
renato-bohler
requested review from
ianschmitz, iansu, mrmckeb and petetnt
as code ownersJanuary 8, 2020 03:53
heyimalex
approved these changes
Jan 8, 2020
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
renato-bohler
commented
Feb 7, 2020
ContributorAuthor
Hmm, any thoughts @andriijas, @ianschmitz? I really don't think this should be closed. |
ianschmitz
approved these changes
Feb 7, 2020
andriijas
commented
Feb 8, 2020
Contributor
Thanks @renato-bohler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8291.
Tested executing
PUBLIC_URL=http://renato-bohler.github.io/my-app yarn buildoncreate-react-approot folder before and after changes.Before changes (c03bb36)
After changes (fe7904a)