Uh oh!
There was an error while loading. Please reload this page.
Update commit message to use imperative mood - #8377
Conversation
facebook-github-bot
commented
Jan 26, 2020
Hi devgeist! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
commented
Jan 26, 2020
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
andriijas
commented
Jan 31, 2020
Thanks for your contribution! |
Why:
As per best practice:
https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches#n135
See also:
https://chris.beams.io/posts/git-commit/#imperative