Skip to content

setupTestFrameworkScriptFile is deprecated - #8390

Merged
andriijas merged 2 commits into
react:masterfrom
JimmyLv:patch-1
Jan 31, 2020
Merged

setupTestFrameworkScriptFile is deprecated#8390
andriijas merged 2 commits into
react:masterfrom
JimmyLv:patch-1

Conversation

@JimmyLv

@JimmyLvJimmyLv commented Jan 29, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Note: setupTestFrameworkScriptFile is deprecated in favor of setupFilesAfterEnv.

ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array

@JimmyLv
setupTestFrameworkScriptFile is deprecated
7c26a9f
__Note:_ `_setupTestFrameworkScriptFile_` _is deprecated in favor of_ `_setupFilesAfterEnv_`_.__
ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array
@facebook-github-bot

facebook-github-bot commented Jan 29, 2020

Copy link
Copy Markdown

Hi JimmyLv! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@amyrlam

amyrlam commented Jan 29, 2020

Copy link
Copy Markdown
Contributor

@JimmyLv Thanks for including the reference link! Looks good 👍, please sign the CLA.

@amyrlamamyrlam self-assigned this Jan 30, 2020
@andriijasandriijas added this to the 3.4 milestone Jan 31, 2020
SimenB
SimenB reviewed Jan 31, 2020
View reviewed changes
Comment threaddocusaurus/docs/running-tests.md Outdated
@JimmyLv@SimenB
Update docusaurus/docs/running-tests.md
8a2c345
Co-Authored-By: Simen Bekkhus <sbekkhus91@gmail.com>
@JimmyLv

JimmyLv commented Jan 31, 2020

Copy link
Copy Markdown
ContributorAuthor

@amyrlam Yes, and I already signed the CLA.

@facebook-github-bot

facebook-github-bot commented Jan 31, 2020

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andriijas
andriijas merged commit 0db04ec into react:masterJan 31, 2020
@locklockBot locked and limited conversation to collaborators Feb 5, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlamamyrlamAwaiting requested review from amyrlam
@iansuiansuAwaiting requested review from iansu
3 more reviewers
@SimenBSimenBSimenB left review comments
@awiboxawiboxawibox approved these changes
@ianschmitzianschmitzianschmitz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@amyrlamamyrlam

Labels

CLA Signedtag: documentation

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@JimmyLv@facebook-github-bot@amyrlam@SimenB@awibox@ianschmitz@andriijas