Remove @babel/core from babel-preset-react-app dependencies

[Andarist]

It's not a dependency of babel-preset-react-app - it's not used anywhere inside it. Potentially it could be set as a peer dependency - just for information purposes, but not sure if you want that. It definitely ain't a hard dependency though.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[Andarist]

I believe the PR is still sound so bumping for the stale bot.

[ianschmitz]

I don't think we can make this change. It causes a whole bunch of peer dependency warnings: https://dev.azure.com/facebook/create-react-app/_build/results?buildId=1242&view=logs&jobId=8999f565-280a-527f-721e-375d49cc4cd5&j=8999f565-280a-527f-721e-375d49cc4cd5&t=7980f6bf-f3f8-5575-47e3-a23aae330cb3

[Andarist]

If you want to keep @babel/core as hard dependency then you might want to move it to react-scripts or something and make @babel/core a peer of babel-preset-react-app.

Right now it being a hard dependency of babel-preset-react-app doesn't make sense - it's never required by the babel-preset-react-app. The @babel/core is always provided externally by the caller to your preset so any version used as a hard dependency of your preset is just hiding a potential issue as that version won't ever actually be used (unless hoisted, but that makes it only working by accident).

[ianschmitz]

We do have it in react-scripts already. I agree we should change it to a peer dep though. It would make sense to follow official babel preset packages convention: https://github.com/babel/babel/blob/master/packages/babel-preset-react/package.json