Uh oh!
There was an error while loading. Please reload this page.
favicon.ico spelled incorrectly in index.html - #845
Conversation
facebook-github-bot
commented
Oct 4, 2016
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
facebook-github-bot
commented
Oct 4, 2016
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gaearon
commented
Oct 4, 2016
Thanks! |
…react-app # By Dan Abramov (2) and others # Via Dan Abramov * 'master' of https://github.com/facebookincubator/create-react-app: Correct a comment mistype in webpack production config (react#855) load setupTests file at setupTestFramework stage (react#846) Spell check (react#845) Tweak readme Update instructions on publishing to GitHub pages (react#841) Make webpackHotDevClient support webpack 2 too (react#840) Tweak eject output Promote "React must be in scope" to be an error (react#822) Fix script name to open chrome (react#831)
IBwWG
left a comment
There was a problem hiding this comment.
This makes for very odd reading when %PUBLIC_URL% happens to be blank, as it was in a starter package I found. "Unlike A or B, A..." (A is unlike A...hmm...)
gaearon
commented
Feb 24, 2017
If you have ideas on improving the wording please don't hesitate to send a PR. |
IBwWG
commented
Feb 24, 2017
…react-app # By Dan Abramov (2) and others # Via Dan Abramov * 'master' of https://github.com/facebookincubator/create-react-app: Correct a comment mistype in webpack production config (react#855) load setupTests file at setupTestFramework stage (react#846) Spell check (react#845) Tweak readme Update instructions on publishing to GitHub pages (react#841) Make webpackHotDevClient support webpack 2 too (react#840) Tweak eject output Promote "React must be in scope" to be an error (react#822) Fix script name to open chrome (react#831)
No description provided.