Skip to content

Add React.StrictMode to default templates - #8558

Merged
ianschmitz merged 5 commits into
react:masterfrom
connkat:strictmode-on-template
Mar 10, 2020
Merged

Add React.StrictMode to default templates#8558
ianschmitz merged 5 commits into
react:masterfrom
connkat:strictmode-on-template

Conversation

@connkat

@connkatconnkat commented Feb 26, 2020•
edited by ianschmitz
Loading

Copy link
Copy Markdown
Contributor

Added in <React.StrictMode> tags to the default templates.

Closes#8557

@ianschmitzianschmitz modified the milestones: 100.0, 3.4.1Feb 27, 2020
ianschmitz
ianschmitz suggested changes Feb 27, 2020
View reviewed changes

@ianschmitzianschmitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these into the index file and wrap the rendering of App there. Also it looks like Prettier wasn't run on commit.

@mrmckeb

mrmckeb commented Feb 29, 2020

Copy link
Copy Markdown
Contributor

@connkat let us know if you need any help with that change.

@ianschmitz

ianschmitz commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

@connkat are you able to update the PR with the suggestions? If not no worries we can get 'er fixed up!

@connkat

connkat commented Mar 5, 2020

Copy link
Copy Markdown
ContributorAuthor

@ianschmitz I can totally get this done by the weekend! Got distracted with some other things IRL but should have the PR up by Sat.

@connkat
connkatforce-pushed the strictmode-on-template branch from ecccbc2 to af82b63CompareMarch 7, 2020 18:42
@connkat
connkat requested a review from ianschmitzMarch 7, 2020 19:09
@gaearon

gaearon commented Mar 8, 2020

Copy link
Copy Markdown
Contributor

Thank you @connkat! I made a few small changes — looks like you forgot to revert the changes in App.js. I think this is good to go now but I'll defer to @ianschmitz to merge.

@ianschmitzianschmitz changed the title added strictmode tags to default templatesAdd React.StrictMode to default templatesMar 8, 2020
mrmckeb
mrmckeb approved these changes Mar 9, 2020
View reviewed changes

@mrmckebmrmckeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @connkat - @ianschmitz I think this is good to go.

@ianschmitz

ianschmitz commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

I'm just working on fixing CI in master.

@ianschmitzianschmitz reopened this Mar 9, 2020
@ianschmitz
ianschmitz merged commit 6adb82a into react:masterMar 10, 2020
@ianschmitz

ianschmitz commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

Thanks!

@locklockBot locked and limited conversation to collaborators Mar 17, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iansuiansuAwaiting requested review from iansu
@petetntpetetntAwaiting requested review from petetnt
2 more reviewers
@mrmckebmrmckebmrmckeb approved these changes
@ianschmitzianschmitzianschmitz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: enhancement

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

Wrap in StrictMode by default

5 participants

@connkat@mrmckeb@ianschmitz@gaearon@facebook-github-bot