Skip to content

Dispose error overlay when linting errors have been corrected - #856

Merged
gaearon merged 3 commits into
react:masterfrom
jarlef:master
Oct 11, 2016
Merged

Dispose error overlay when linting errors have been corrected#856
gaearon merged 3 commits into
react:masterfrom
jarlef:master

Conversation

@jarlef

@jarlefjarlef commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

Remove error overlay when linting errors have been corrected and the next webpack linting is successful / contains only warnings.

@facebook-github-bot

facebook-github-bot commented Oct 5, 2016

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Oct 5, 2016

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

wdhorton
wdhorton reviewed Oct 8, 2016
View reviewed changes
Comment threadpackages/react-dev-utils/webpackHotDevClient.js Outdated
});
}

function destoryOverlay() {

@wdhortonwdhortonOct 8, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, but you probably meant "destroy" rather than "destory", right?

@jarlefjarlefOct 10, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. pardon my spelling error ;-)

@gaearongaearon added this to the 0.7.0 milestone Oct 11, 2016
@gaearon
gaearon merged commit 4e5a561 into react:masterOct 11, 2016
@gaearon

gaearon commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

Thanks!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@jarlef@feiqitian
Dispose error overlay when linting errors have been corrected (react#856
31d2b99
)
* Dispose error overlay when linting errors have been corrected
* Fixed spelling error
* Minor style tweaks
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@wdhortonwdhortonwdhorton left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jarlef@facebook-github-bot@gaearon@wdhorton