Skip to content

Indicate that the file structure is the template's - #8561

Merged
mrmckeb merged 1 commit into
react:masterfrom
Vinnl:patch-3
Feb 29, 2020
Merged

Indicate that the file structure is the template's#8561
mrmckeb merged 1 commit into
react:masterfrom
Vinnl:patch-3

Conversation

@Vinnl

Copy link
Copy Markdown
Contributor

The directory tree that's currently shown is the structure that a CRA template should have, but my-app is used earlier in this tutorial to refer to the app that's generated based on that template.

@mrmckebmrmckeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst this is not actually required - only the published name needs to be in this format - I think this makes sense.

@mrmckeb
mrmckeb merged commit 7d3b72c into react:masterFeb 29, 2020
@mrmckeb

Copy link
Copy Markdown
Contributor

Merged, thanks @Vinnl!

@locklockBot locked and limited conversation to collaborators Mar 10, 2020
@ianschmitzianschmitz added this to the 3.4.1 milestone Mar 20, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Vinnl@mrmckeb@ianschmitz@facebook-github-bot