Uh oh!
There was an error while loading. Please reload this page.
Add back in --stats output from webpack. - #8790
Merged
Merged
Conversation
This commit is a manual revert of the following commits: react@e7a427areact@140e182 And a re-introduction of react@7c85938Fixes: react#8789Fixes: react#6904 Tested: Manually ran yarn link and then ran yarn build from a 3.x version of CRA with react-scripts linked in from this patch. Verification: Saw that a bundle-stats.json file was written out where as before in the pre-linked version it was not.
samccone
requested review from
ianschmitz, iansu, mrmckeb and petetnt
as code ownersApril 5, 2020 20:23
montogeek
approved these changes
Apr 5, 2020
samccone
commented
Apr 12, 2020
ContributorAuthor
👋 all, I am happy to assist in any way to help move this along. I am more than willing to donate time to helping review open PRs, issues, and or anything else that you would find valuable. I know y'all are working on a purely volunteer basis and here I am asking for your time and energy to look into my work. As such it is only reasonable for me to help. Let me know how I can help and what I can do. Thank you! |
samccone
commented
May 3, 2020
ContributorAuthor
👋 friendly bump, let me know if there is anything i can do to help. |
iansu
commented
May 5, 2020
Contributor
Thanks! |
samccone
commented
May 5, 2020
ContributorAuthor
thank you!! |
donavon
commented
May 12, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a manual revert of the following commits:
e7a427a
140e182
And a re-introduction of
7c85938
Fixes: #8789
Fixes: #6904
Tested:
Manually ran yarn link and then ran yarn build from a 3.x version of CRA
with react-scripts linked in from this patch.
Verification:
Saw that a bundle-stats.json file was written out where as before in the
pre-linked version it was not.