Skip to content

Add support for postcss.config.js - #8907

Closed
piecyk wants to merge 1 commit into
react:masterfrom
piecyk:feature/postcss-config
Closed

Add support for postcss.config.js#8907
piecyk wants to merge 1 commit into
react:masterfrom
piecyk:feature/postcss-config

Conversation

@piecyk

@piecykpiecyk commented Apr 26, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request addressed the issue of supporting custom postcss.config.js. It's third one after #8474#8331 🙈

Basic idea here is to check if we have config same way postcss-loader does.

@facebook-github-bot

facebook-github-bot commented Apr 26, 2020

Copy link
Copy Markdown

Hi @piecyk!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Apr 26, 2020

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@piecyk
piecykforce-pushed the feature/postcss-config branch from fcd2292 to b5c6338CompareApril 28, 2020 16:56
@pspeter3

pspeter3 commented May 7, 2020

Copy link
Copy Markdown

What's the difference between this an #8331?

@piecyk

piecyk commented May 7, 2020

Copy link
Copy Markdown
Author

@pspeter3 here we use the same logic as postcss-loader to resolve config using postcss-load-config. #8331 is checking it by hand using cosmiconfig.

@piecyk
piecykforce-pushed the feature/postcss-config branch 2 times, most recently from 4d4bc0b to 0d0c6beCompareMay 7, 2020 20:14
@pspeter3

pspeter3 commented May 7, 2020

Copy link
Copy Markdown

Cool! Well hopefully this gets accepted. It would be nice to override the PostCSS config.

@piecyk
piecykforce-pushed the feature/postcss-config branch from 0d0c6be to 93b1545CompareMay 7, 2020 20:16
@piecyk
piecykforce-pushed the feature/postcss-config branch 2 times, most recently from f5223a9 to 0feb76bCompareMay 20, 2020 13:21
@piecyk
Check if postcss-load-config will resolve config if not use default o…
384401a
…ptions
- Update post-processing-css.md
- Add test
- Add postcss-load-config as react-scripts dependency
@piecyk
piecykforce-pushed the feature/postcss-config branch from 0feb76b to 384401aCompareMay 20, 2020 13:41
@piecyk

piecyk commented May 20, 2020

Copy link
Copy Markdown
Author

Should be ready 👋

@piecyk

piecyk commented May 27, 2020

Copy link
Copy Markdown
Author

ping @ianschmitz@mrmckeb

@stale

staleBot commented Jun 26, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Jun 26, 2020
@piecyk

piecyk commented Jun 26, 2020

Copy link
Copy Markdown
Author

Maybe not stale? 🤷‍♂️

@stalestaleBot removed the stale label Jun 26, 2020
@mikefrancis

mikefrancis commented Jun 26, 2020

Copy link
Copy Markdown
Contributor

I have everything crossed this makes it into the next version 🤞

@stale

staleBot commented Jul 26, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Jul 26, 2020
@alexlanz

alexlanz commented Jul 27, 2020

Copy link
Copy Markdown

Please don't close this PR!! This would help us a lot. We are looking forward to see custom postcss configurations

@stalestaleBot removed the stale label Jul 27, 2020
@amyrlam
amyrlam removed their request for review August 24, 2020 05:39
@piecyk

piecyk commented Aug 24, 2020

Copy link
Copy Markdown
Author

@iansu@gaearon would you mind taking a look once you have a moment 🙏

@pspeter3

pspeter3 commented Sep 9, 2020

Copy link
Copy Markdown

This would be a huge win, especially with recent popularity of Tailwind which requires a PostCSS configuration file.

Ishaan28malik
Ishaan28malik approved these changes Sep 10, 2020
View reviewed changes

@Ishaan28malikIshaan28malik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piecykpiecyk mentioned this pull request Oct 1, 2020
Closed
@tomspeak

tomspeak commented Nov 16, 2020

Copy link
Copy Markdown

Is it possible to get any insight into when this could potentially be released? Soon? Next major release?

@geekdada

geekdada commented Nov 22, 2020

Copy link
Copy Markdown

This really helps a lot!

@max8hine

max8hine commented Nov 23, 2020

Copy link
Copy Markdown

It would be great that the user can in charge of the PostCSS build.

@sahilpurav

sahilpurav commented Nov 24, 2020

Copy link
Copy Markdown
Contributor

This is a great feature! I was hoping to build it if it isn't initiated.

@sahilpuravsahilpurav mentioned this pull request Nov 24, 2020
Closed
@stale

staleBot commented Dec 25, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Dec 25, 2020
@marco-carvalho

marco-carvalho commented Dec 28, 2020

Copy link
Copy Markdown

don't close this PR!

@stalestaleBot removed the stale label Dec 28, 2020
@joshmanders

joshmanders commented Jan 10, 2021

Copy link
Copy Markdown

Any update on this?

@GeoffSelby

GeoffSelby commented Jan 11, 2021•
edited
Loading

Copy link
Copy Markdown

Any update on this?

@joshmanders I don’t see it happening anytime soon. That’s why I made a custom fork and implemented it myself.

Using my fork with my cra-template-tailwindcss template is the way to go if you are looking for create react app with tailwind support 👍

@joshmanders

joshmanders commented Jan 11, 2021

Copy link
Copy Markdown

@GeoffSelby oh I didn't know you made one. I keep checking back on CRA about having more support for things and see it's always just PR or Issue after PR/Issue with no updates or feedback.

May as well just stay with Next.js

@phatedphated mentioned this pull request Jan 26, 2021
Open
@alesso-xalesso-x mentioned this pull request Feb 21, 2021
Open
@piecyk

piecyk commented Mar 31, 2021

Copy link
Copy Markdown
Author

Resolved via #10003

@piecykpiecyk closed this Mar 31, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt
1 more reviewer
@Ishaan28malikIshaan28malikIshaan28malik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@piecyk@facebook-github-bot@pspeter3@mikefrancis@alexlanz@tomspeak@geekdada@max8hine@sahilpurav@marco-carvalho@joshmanders@GeoffSelby@Ishaan28malik