Skip to content

Update deployment docs for Azure Static Web Apps - #9042

Merged
ianschmitz merged 3 commits into
react:masterfrom
burkeholland:azure-deployment
Jun 14, 2020
Merged

Update deployment docs for Azure Static Web Apps#9042
ianschmitz merged 3 commits into
react:masterfrom
burkeholland:azure-deployment

Conversation

@burkeholland

@burkehollandburkeholland commented May 21, 2020

Copy link
Copy Markdown
Contributor

Just an update to the Azure docs for deployment for the new Azure Static Web Apps.

@facebook-github-bot

facebook-github-bot commented May 21, 2020

Copy link
Copy Markdown

Hi @burkeholland!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented May 21, 2020

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

petetnt
petetnt approved these changes May 21, 2020
View reviewed changes

@petetntpetetnt left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure Static Web Apps are really neat, congrats on the launch!

LGTM with a nit Github -> GitHub

@burkeholland
Github -> GitHub
7184e70
Great catch!
NMinhNguyen
NMinhNguyen reviewed May 22, 2020
View reviewed changes
Comment threaddocusaurus/docs/deployment.md Outdated
NMinhNguyen
NMinhNguyen reviewed May 22, 2020
View reviewed changes
Comment threaddocusaurus/docs/deployment.md Outdated
burkeholland
burkeholland commented May 22, 2020
View reviewed changes

@burkehollandburkeholland left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@burkeholland@NMinhNguyen
Apply suggestions from code review
1eac1fb
Thank you!
Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com>
@burkeholland

burkeholland commented Jun 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Just checking back on this. Looks like the checks didn't pass, but that doesn't look like it's specific to my PR. Let me know if there is anything else I need to change here.

@ianschmitzianschmitz added this to the 4.0 milestone Jun 14, 2020
@ianschmitz

ianschmitz commented Jun 14, 2020

Copy link
Copy Markdown
Contributor

All good @burkeholland. Thanks for the update and congrats on the launch as well 😄

@ianschmitzianschmitz changed the title Update for Azure Static Web AppsUpdate deployment docs for Azure Static Web AppsJun 14, 2020
@ianschmitz
ianschmitz merged commit b389928 into react:masterJun 14, 2020
@locklockBot locked and limited conversation to collaborators Jun 24, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlamamyrlamAwaiting requested review from amyrlam
@iansuiansuAwaiting requested review from iansu
2 more reviewers
@NMinhNguyenNMinhNguyenNMinhNguyen left review comments
@petetntpetetntpetetnt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signedtag: documentation

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@burkeholland@facebook-github-bot@ianschmitz@NMinhNguyen@petetnt