Skip to content

Add performance relayer + documentation (web-vitals) - #9116

Merged
ianschmitz merged 6 commits into
react:masterfrom
housseindjirdeh:add-performance-relayer
Jun 11, 2020
Merged

Add performance relayer + documentation (web-vitals)#9116
ianschmitz merged 6 commits into
react:masterfrom
housseindjirdeh:add-performance-relayer

Conversation

@housseindjirdeh

@housseindjirdehhousseindjirdeh commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Fixes#8996

Changes included:

  • Dynamically imports the web-vitals lib
  • Includes a reportWebVitals function to index.js template (doesn't do anything until a function is passed in)
  • Adds a "Measuring Performance" page to the documentation

@facebook-github-bot

Copy link
Copy Markdown

Hi @housseindjirdeh!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Comment threadpackages/cra-template/template/src/index.js

@mrmckebmrmckeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but it looks good at an overview, and the docs look great. This is something we definitely talked about getting into the next release - and I'd love to see it make it.

Thoughts @ianschmitz@iansu?

Comment threadpackages/react-scripts/package.json Outdated
Comment threadpackages/cra-template/template/src/reportWebVitals.js
@iansuiansu mentioned this pull request Jun 7, 2020
23 tasks
@mrmckebmrmckeb added this to the 4.0 milestone Jun 9, 2020

@kentcdoddskentcdodds left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think this is good to go 👍

@mrmckeb

mrmckeb commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

I've tested this on a project today and it works well. Obviously the extension works with or without this, but being able to report on this is really valuable.

@ianschmitzianschmitz changed the title Adds performance relayer + documentation (web-vitals)Add performance relayer + documentation (web-vitals)Jun 11, 2020
@ianschmitz
ianschmitz merged commit 8fda779 into react:masterJun 11, 2020
@ianschmitz

Copy link
Copy Markdown
Contributor

Thanks a ton @housseindjirdeh! Much appreciated.

@housseindjirdeh

Copy link
Copy Markdown
ContributorAuthor

Awesome thanks all! So happy to see this land :)

@locklockBot locked and limited conversation to collaborators Jun 24, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include a performance relayer

6 participants

@housseindjirdeh@facebook-github-bot@mrmckeb@ianschmitz@kentcdodds@petetnt