Skip to content

Allow webpack 2 as peerDependency in react-dev-utils - #963

Merged
gaearon merged 2 commits into
react:masterfrom
einarlove:patch-1
Oct 31, 2016
Merged

Allow webpack 2 as peerDependency in react-dev-utils#963
gaearon merged 2 commits into
react:masterfrom
einarlove:patch-1

Conversation

@einarlove

Copy link
Copy Markdown
Contributor

Now that webpackHotDevClient support webpack 2, react-dev-utils should allow the most recent beta release to 🐱.

@gaearon

Copy link
Copy Markdown
Contributor

Let's remove it altogether?

@einarlove

Copy link
Copy Markdown
ContributorAuthor

Sure. I'll update the PR tomorrow.

@gaearongaearon added this to the 0.8.0 milestone Oct 31, 2016
@gaearon
gaearon merged commit e3b6966 into react:masterOct 31, 2016
@gaearon

Copy link
Copy Markdown
Contributor

👍

@einarlove
einarlove deleted the patch-1 branch October 31, 2016 11:54
@TimerTimer mentioned this pull request Nov 4, 2016
kitze added a commit to kitze/custom-react-scripts that referenced this pull request Nov 4, 2016
…react-app
# By Ville Immonen (11) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app: (39 commits)
Remove redundant `function` from export statement (react#996)
Add Gatsby to alternatives (react#995)
Allow webpack 2 as peerDependency in react-dev-utils (react#963)
Remove custom babel-loader cache dir config (react#983)
Check for presence of folders before continuing eject. Closesreact#939. (react#951)
Fixesreact#952 (react#953)
Always build before deploying to gh-pages (react#959)
Add collectCoverageFrom option to collect coverage on files without any tests. (react#961)
Catch and noop call to open web browser. (react#964)
Gently nudge users towards https by default (react#974)
Enable compression on webpack-dev-server (react#966) (react#968)
Add next.js to Alternatives
Point people to npm Windows instructions
Encourage people to try recent npm
Fix an attribution link in 0.7.0 changelog
Update CLI version in changelog
Publish
Update eslint-config-react-app version in the guide
Update changelog for 0.7.0
Revert "Temporarily remove 0.7.0 changelog as it's not out yet"
...
Conflicts:
packages/babel-preset-react-app/package.json
packages/create-react-app/package.json
packages/eslint-config-react-app/package.json
packages/react-dev-utils/package.json
packages/react-scripts/config/webpack.config.dev.js
packages/react-scripts/config/webpack.config.prod.js
packages/react-scripts/package.json
eXtreme added a commit to eXtreme/create-react-app that referenced this pull request Nov 18, 2016
* pull2:
Support Yarn (react#898)
Fix chrome tab reuse (react#1035)
Remove unnecessary transform plugins for object spread to work (react#1052)
Clears the usage of react-jsx-source & react-jsx-self (react#992)
Update babel-present-env and use node: 'current' as target (react#1051)
Remove redundant `function` from export statement (react#996)
Add Gatsby to alternatives (react#995)
Allow webpack 2 as peerDependency in react-dev-utils (react#963)
Remove custom babel-loader cache dir config (react#983)
Check for presence of folders before continuing eject. Closesreact#939. (react#951)
Fixesreact#952 (react#953)
Always build before deploying to gh-pages (react#959)
Add collectCoverageFrom option to collect coverage on files without any tests. (react#961)
Catch and noop call to open web browser. (react#964)
Gently nudge users towards https by default (react#974)
Enable compression on webpack-dev-server (react#966) (react#968)
Add next.js to Alternatives
Point people to npm Windows instructions
Encourage people to try recent npm
# Conflicts:
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/package.json
#	packages/react-scripts/utils/createJestConfig.js
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
* Allow webpack 2 as peerDependency
* Remove webpack as peer dependency
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Allow webpack 2 as peerDependency
* Remove webpack as peer dependency
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
* Allow webpack 2 as peerDependency
* Remove webpack as peer dependency
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this pull request Mar 7, 2018
…react-app
# By Ville Immonen (11) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app: (39 commits)
Remove redundant `function` from export statement (react#996)
Add Gatsby to alternatives (react#995)
Allow webpack 2 as peerDependency in react-dev-utils (react#963)
Remove custom babel-loader cache dir config (react#983)
Check for presence of folders before continuing eject. Closesreact#939. (react#951)
Fixesreact#952 (react#953)
Always build before deploying to gh-pages (react#959)
Add collectCoverageFrom option to collect coverage on files without any tests. (react#961)
Catch and noop call to open web browser. (react#964)
Gently nudge users towards https by default (react#974)
Enable compression on webpack-dev-server (react#966) (react#968)
Add next.js to Alternatives
Point people to npm Windows instructions
Encourage people to try recent npm
Fix an attribution link in 0.7.0 changelog
Update CLI version in changelog
Publish
Update eslint-config-react-app version in the guide
Update changelog for 0.7.0
Revert "Temporarily remove 0.7.0 changelog as it's not out yet"
...
Conflicts:
packages/babel-preset-react-app/package.json
packages/create-react-app/package.json
packages/eslint-config-react-app/package.json
packages/react-dev-utils/package.json
packages/react-scripts/config/webpack.config.dev.js
packages/react-scripts/config/webpack.config.prod.js
packages/react-scripts/package.json
@locklockBot locked and limited conversation to collaborators Jan 22, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@einarlove@gaearon@fson@facebook-github-bot