Skip to content

refactor: remove usage of var in babel-preset-react-app - #9648

Open
tobiasbueschel wants to merge 1 commit into
react:mainfrom
tobiasbueschel:refactor/const
Open

refactor: remove usage of var in babel-preset-react-app#9648
tobiasbueschel wants to merge 1 commit into
react:mainfrom
tobiasbueschel:refactor/const

Conversation

@tobiasbueschel

@tobiasbuescheltobiasbueschel commented Sep 16, 2020

Copy link
Copy Markdown
Contributor

As discussed with @mrmckeb this PR removes the legacy usage of var within babel-preset-react-app: https://github.com/facebook/create-react-app/pull/9645/files#r489211419

tobiasbueschel
tobiasbueschel commented Sep 16, 2020
View reviewed changes
Comment threadpackages/babel-preset-react-app/README.md Outdated
@tobiasbuescheltobiasbueschel mentioned this pull request Sep 16, 2020
Merged
tobiasbueschel
tobiasbueschel commented Sep 16, 2020
View reviewed changes
Comment threadpackages/babel-preset-react-app/create.js Outdated
@tobiasbueschel

tobiasbueschel commented Sep 17, 2020

Copy link
Copy Markdown
ContributorAuthor

The fix was released in PostCSS 7.0.34. This PR can be removed.

Hi @ai, I think you might have accidentally commented on the wrong PR - this one is not related to PostCSS, but rather to the legacy usage of var.

@stale

staleBot commented Dec 25, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Dec 25, 2020
@tobiasbueschel

tobiasbueschel commented Jan 4, 2021

Copy link
Copy Markdown
ContributorAuthor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

Please keep the PR open.

@stalestaleBot removed the stale label Jan 4, 2021
@stale

staleBot commented Jan 9, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stalestaleBot added the stale label Jan 9, 2022
@tobiasbueschel

tobiasbueschel commented Jan 10, 2022

Copy link
Copy Markdown
ContributorAuthor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

👋

@stalestaleBot removed the stale label Jan 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianschmitzianschmitzAwaiting requested review from ianschmitz
@iansuiansuAwaiting requested review from iansu
@mrmckebmrmckebAwaiting requested review from mrmckeb
@petetntpetetntAwaiting requested review from petetnt

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasbueschel@facebook-github-bot