Skip to content

fix: add react-refresh as a dependency for templates#9671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmmmwh wants to merge 2 commits into from
Closed

fix: add react-refresh as a dependency for templates #9671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a3d12f
fix: add react-refresh as a dependency for templates
pmmmwh Sep 20, 2020
40c7c4d
fix: move react-refresh dep into cra command
pmmmwh Oct 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions packages/create-react-app/createReactApp.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -158,7 +158,7 @@ function init() {
'Firefox',
'Safari',
],
npmPackages: ['react', 'react-dom', 'react-scripts'],
npmPackages: ['react', 'react-dom', 'react-refresh', 'react-scripts'],
npmGlobalPackages: ['create-react-app'],
},
{
Expand DownExpand Up@@ -431,7 +431,12 @@ function run(
getInstallPackage(version, originalDirectory),
getTemplateInstallPackage(template, originalDirectory),
]).then(([packageToInstall, templateToInstall]) => {
const allDependencies = ['react', 'react-dom', packageToInstall];
const allDependencies = [
'react',
'react-dom',
'react-refresh',
packageToInstall,
];

console.log('Installing packages. This might take a couple of minutes.');

Expand DownExpand Up@@ -476,7 +481,9 @@ function run(
console.log(
`Installing ${chalk.cyan('react')}, ${chalk.cyan(
'react-dom'
)}, and ${chalk.cyan(packageInfo.name)}${
)}, ${chalk.cyan('react-refresh')}, and ${chalk.cyan(
packageInfo.name
)}${
supportsTemplates ? ` with ${chalk.cyan(templateInfo.name)}` : ''
}...`
);
Expand DownExpand Up@@ -869,7 +876,12 @@ function checkAppName(appName) {
}

// TODO: there should be a single place that holds the dependencies
const dependencies = ['react', 'react-dom', 'react-scripts'].sort();
const dependencies = [
'react',
'react-dom',
'react-refresh',
'react-scripts',
].sort();
if (dependencies.includes(appName)) {
console.error(
chalk.red(
Expand DownExpand Up@@ -924,6 +936,7 @@ function setCaretRangeForRuntimeDeps(packageName) {

makeCaretRange(packageJson.dependencies, 'react');
makeCaretRange(packageJson.dependencies, 'react-dom');
makeCaretRange(packageJson.devDependencies, 'react-refresh');

fs.writeFileSync(packagePath, JSON.stringify(packageJson, null, 2) + os.EOL);
}
Expand Down