Skip to content

Fix #9880 - #9943

Closed
femesq wants to merge 2 commits into
react:masterfrom
femesq:patch-1
Closed

Fix #9880#9943
femesq wants to merge 2 commits into
react:masterfrom
femesq:patch-1

Conversation

@femesq

Copy link
Copy Markdown

Fix formatting error on webpack v5, as described here: #9880

Specifically in this link, on the item that says:

Stats json errors and warnings no longer contain strings but objects with information splitted into properties.
MIGRATION: Access the information on the properties. i. e. message

Fix formatting error on webpack v5, as described here: react#9880
Specifically in [this link](https://webpack.js.org/blog/2020-10-10-webpack-5-release/#minor-changes), on the item that says:
Stats json errors and warnings no longer contain strings but objects with information splitted into properties.
MIGRATION: Access the information on the properties. i. e. message
@moonjoungyoung

Copy link
Copy Markdown

Any update?

@vagrantsnvagrantsn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works after applying the fix I suggested! 🚀

Comment threadpackages/react-dev-utils/formatWebpackMessages.js Outdated
@mrmckebmrmckeb added this to the 4.0.3 milestone Feb 5, 2021
Co-authored-by: Vagner S <vagners.tambalo@gmail.com>

@vagrantsnvagrantsn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@vagrantsnvagrantsn mentioned this pull request Feb 10, 2021
25 tasks
@iansuiansu modified the milestones: 4.0.3, 4.0.4Feb 22, 2021
@utterly-calm

Copy link
Copy Markdown

It's taking too much to fix this issue. People are suffering in April 2020 as well. Please merge it. Any plans?

@mrmckeb

mrmckeb commented May 30, 2021

Copy link
Copy Markdown
Contributor

Thanks for the patience. This hasn't been a priority for us as we don't support Webpack 5 yet, however I understand this is a non-breaking change for existing users and we'll get this out for in the next release.

Edit: This is one of three similar PRs, we'll get one of these out in the next release - but I'll chat to the team about which approach is best for us.

See: #10098 and #10121.

@mrmckeb

Copy link
Copy Markdown
Contributor

Hi @femesq, thanks for your time on this. After a discussion with @raix, we're closing this in favour of #10121 and plan to have this out in the next minor release. Please let us know if you have any issues after that time!

@mrmckebmrmckeb closed this May 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@femesq@moonjoungyoung@utterly-calm@mrmckeb@vagrantsn@iansu@facebook-github-bot