Uh oh!
There was an error while loading. Please reload this page.
Update /symbolicate handling to parse JSON internally - #1475
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Mar 28, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D71994399 |
3 tasks
huntie added a commit
to huntie/metro
that referenced
this pull request
Mar 28, 2025
Summary: Currently, Metro's `/symbolicate` endpoint is supported by [a hack](react-native-community/cli#1147) in React Native Community CLI. This diff internalises the necessary request body parsing, removing this dependency. Legacy `req.rawBody` handling is preserved for backwards compatibility. Changelog: [Internal] Support correct `application/json` body parsing in `/symbolicate` Reviewed By: robhogan Differential Revision: D71994399
facebook-github-bot
commented
Mar 28, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D71994399 |
huntie added a commit
to huntie/metro
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: react#1475 Currently, Metro's `/symbolicate` endpoint is supported by [a hack](react-native-community/cli#1147) in React Native Community CLI. This diff internalises the necessary request body parsing, removing this dependency. Legacy `req.rawBody` handling is preserved for backwards compatibility. Changelog: [Internal] Support correct `application/json` body parsing in `/symbolicate` Reviewed By: robhogan Differential Revision: D71994399
3 tasks
huntie added a commit
to huntie/metro
that referenced
this pull request
Mar 28, 2025
Summary: Currently, Metro's `/symbolicate` endpoint is supported by [a hack](react-native-community/cli#1147) in React Native Community CLI. This diff internalises the necessary request body parsing, removing this dependency. Legacy `req.rawBody` handling is preserved for backwards compatibility. Changelog: [Internal] Support correct `application/json` body parsing in `/symbolicate` Reviewed By: robhogan Differential Revision: D71994399
facebook-github-bot
commented
Mar 28, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D71994399 |
huntie added a commit
to huntie/metro
that referenced
this pull request
Mar 28, 2025
Summary: Pull Request resolved: react#1475 Currently, Metro's `/symbolicate` endpoint is supported by [a hack](react-native-community/cli#1147) in React Native Community CLI. This diff internalises the necessary request body parsing, removing this dependency. Legacy `req.rawBody` handling is preserved for backwards compatibility. Changelog: [Internal] Support correct `application/json` body parsing in `/symbolicate` Reviewed By: robhogan Differential Revision: D71994399
huntieforce-pushed
the
export-D71994399
branch
2 times, most recently
from
March 28, 2025 17:54
c5d167e to
4519036Comparehuntie added a commit
to huntie/metro
that referenced
this pull request
Mar 28, 2025
Summary: Currently, Metro's `/symbolicate` endpoint is supported by [a hack](react-native-community/cli#1147) in React Native Community CLI. This diff internalises the necessary request body parsing, removing this dependency. Legacy `req.rawBody` handling is preserved for backwards compatibility. Changelog: [Internal] Support correct `application/json` body parsing in `/symbolicate` Reviewed By: robhogan Differential Revision: D71994399
Summary: Pull Request resolved: react#1475 Currently, Metro's `/symbolicate` endpoint is supported by [a hack](react-native-community/cli#1147) in React Native Community CLI. This diff internalises the necessary request body parsing, removing this dependency. Legacy `req.rawBody` handling is preserved for backwards compatibility. Changelog: [Internal] Support correct `application/json` body parsing in `/symbolicate` Reviewed By: robhogan Differential Revision: D71994399
facebook-github-bot
commented
Mar 28, 2025
Contributor
This pull request was exported from Phabricator. Differential Revision: D71994399 |
facebook-github-bot
commented
Mar 30, 2025
Contributor
This pull request has been merged in 2cea6e4. |
3 tasks
kitten added a commit
to expo/expo
that referenced
this pull request
Feb 11, 2026
…ddleware` (#43074) # Why Supersedes #35757 > This removes a longstanding hack that covered for a lack of JSON body parsing in Metro's `/symbolicate` endpoint. We're now resolving this in react/metro#1475 — meaning this can be removed from Expo CLI. > — @huntie This also raised that we had two calls to `/symbolicate` that weren't being called with `application/json`. However, without the `rawBody` property, Metro's middlewares now expect the `Content-Type: application/json` header. # How - Update `@expo/log-box` to set `Content-Type: application/json` on JSON POST requests - Update `@expo/cli` to set `Content-Type: application/json` on internal `/symbolicate` request - Drop `rawBodyMiddleware` from CLI's `createMetroMiddleware` - Replace `rawBody` with JSON body parsing for `/open-stack-frame` # Test Plan - Run app and cause an error with a stack trace - The `/symbolicate` call should work as before - Clicking a frame, `/open-stack-frame` should work as before # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, Metro's
/symbolicateendpoint is supported by a hack in React Native Community CLI. This diff internalises the necessary request body parsing, removing this dependency.Legacy
req.rawBodyhandling is preserved for backwards compatibility.Changelog: [Internal] Support correct
application/jsonbody parsing in/symbolicateDifferential Revision: D71994399