Skip to content

allow parsing frames with eval url - #196

Merged
vzaidman merged 1 commit into
mainfrom
allow-eval-frames-parsing
Jul 23, 2025
Merged

allow parsing frames with eval url#196
vzaidman merged 1 commit into
mainfrom
allow-eval-frames-parsing

Conversation

@vzaidman

Copy link
Copy Markdown

Summary

Following #188, allow frames with the format

 at anonymous (eval:12:2)

coming from Hermes when there's a TypeError or ReferenceError when executing bundles.

Test plan

Before:
Screenshot 2025-07-23 at 10 20 24

After:
Screenshot 2025-07-23 at 10 27 26

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@huntie

Copy link
Copy Markdown
Member

@vzaidman Should the target branch for this PR be main?

@vzaidman

Copy link
Copy Markdown
Author

Yea, I'll change it once the previous branch is merged. Cheers!

@vzaidman
vzaidmanforce-pushed the allow-skipping-x-frames-parsing branch from e9f2055 to 3b58e23CompareJuly 23, 2025 13:38
@vzaidman
vzaidmanforce-pushed the allow-eval-frames-parsing branch 2 times, most recently from 0f401ca to 41ad8d8CompareJuly 23, 2025 13:50
hoxyq
hoxyq approved these changes Jul 23, 2025
@vzaidman
vzaidmanforce-pushed the allow-skipping-x-frames-parsing branch from 3b58e23 to fb5038fCompareJuly 23, 2025 15:15
Base automatically changed from allow-skipping-x-frames-parsing to mainJuly 23, 2025 15:37
@vzaidman
vzaidmanforce-pushed the allow-eval-frames-parsing branch from 41ad8d8 to c1da2dfCompareJuly 23, 2025 15:42
@vzaidman

Copy link
Copy Markdown
Author

@huntie notice-

Base automatically changed from allow-skipping-x-frames-parsing to main

once you merge the branch it changes to main automatically. I just needed to specify in my PR that it is 2/2.

@vzaidman
vzaidman merged commit a7e4f59 into mainJul 23, 2025
5 checks passed
@vzaidman
vzaidman deleted the allow-eval-frames-parsing branch July 23, 2025 16:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vzaidman@huntie@hoxyq@facebook-github-bot