Skip to content

feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoxyq merged 1 commit into from
Apr 15, 2024
Merged

feat: use and initialize RDT Frontend in RDT panel #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 84 additions & 14 deletions front_end/panels/react_devtools/ReactDevToolsView.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
static instance(): ReactDevToolsViewImpl {
if (!instance) {
instance = new ReactDevToolsViewImpl();
}
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
/**
*@description Title of the React DevTools view
*/
title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
private readonly wall: ReactDevToolsTypes.Wall;
private readonly bridge: ReactDevToolsTypes.Bridge;
private readonly store: ReactDevToolsTypes.Store;
private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

constructor() {
super(i18nString(UIStrings.title));

this.wall = {
listen: (listener): Function => {
this.listeners.add(listener);

return (): void => {
this.listeners.delete(listener);
};
},
send: (event, payload): void => this.sendMessage(event, payload),
};

// To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
this.bridge = ReactDevTools.createBridge(this.wall);
this.store = ReactDevTools.createStore(this.bridge);

SDK.TargetManager.TargetManager.instance().addModelListener(
ReactDevToolsModel,
Events.MessageReceived,
this.onMessage,
this,
);

return instance;
SDK.TargetManager.TargetManager.instance().addModelListener(
ReactDevToolsModel,
Events.Initialized,
this.initialize,
this,
);

const loaderContainer = document.createElement('div');
loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

const loader = document.createElement('span');
loader.classList.add('spinner');

loaderContainer.appendChild(loader);
this.contentElement.appendChild(loaderContainer);
}

private constructor() {
super(true, true);
private initialize(): void {
// Remove loader
this.contentElement.removeChildren();

const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

this.registerCSSFiles([ReactDevTools.CSS]);
ReactDevTools.initialize(this.contentElement, {
bridge: this.bridge,
store: this.store,
theme: usingDarkTheme ? 'dark' : 'light',

@motiz88motiz88Apr 15, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:

  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?

@hoxyqhoxyqApr 15, 2024•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?

Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.

Does CDT allow the user to override the theme? Will this honour that setting?

Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.

});
}

override wasShown(): void {
super.wasShown();
private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
if (!event.data) {
return;
}

this.render();
for (const listener of this.listeners) {
listener(event.data);
}
}

render(): void {
return;
private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
void model.sendMessage({event, payload});
}
}
}
2 changes: 1 addition & 1 deletion front_end/panels/react_devtools/react_devtools-meta.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
condition: null,
})) {
return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
}

return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down
16 changes: 16 additions & 0 deletions scripts/build/generate_html_entrypoint.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
);
}

// React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
// https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
// Here we update the CSP header to allow workers from self
if (entrypoint === 'rn_fusebox') {
const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
if (cspHeaderMatch === null) {
throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
}

rewrittenTemplateContent = rewrittenTemplateContent.replace(
cspHeaderRegex,
'$1; worker-src \'self\' blob:'
);
}

writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat: use and initialize RDT Frontend in RDT panel by hoxyq · Pull Request #23 · react/react-native-devtools-frontend · GitHub
Skip to content
feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Apr 15, 2024
 Merged


feat: use and initialize RDT Frontend in RDT panel
#23
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


98 changes: 84 additions & 14 deletions
front_end/panels/react_devtools/ReactDevToolsView.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
 static instance(): ReactDevToolsViewImpl {
 if (!instance) {
 instance = new ReactDevToolsViewImpl();
 }
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
 /**
 *@description Title of the React DevTools view
 */
 title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
 private readonly wall: ReactDevToolsTypes.Wall;
 private readonly bridge: ReactDevToolsTypes.Bridge;
 private readonly store: ReactDevToolsTypes.Store;
 private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

 constructor() {
 super(i18nString(UIStrings.title));

 this.wall = {
 listen: (listener): Function => {
 this.listeners.add(listener);

 return (): void => {
 this.listeners.delete(listener);
 };
 },
 send: (event, payload): void => this.sendMessage(event, payload),
 };

 // To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
 this.bridge = ReactDevTools.createBridge(this.wall);
 this.store = ReactDevTools.createStore(this.bridge);

 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.MessageReceived,
 this.onMessage,
 this,
 );

 return instance;
 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.Initialized,
 this.initialize,
 this,
 );

 const loaderContainer = document.createElement('div');
 loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

 const loader = document.createElement('span');
 loader.classList.add('spinner');

 loaderContainer.appendChild(loader);
 this.contentElement.appendChild(loaderContainer);
 }

 private constructor() {
 super(true, true);
 private initialize(): void {
 // Remove loader
 this.contentElement.removeChildren();

 const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

 this.registerCSSFiles([ReactDevTools.CSS]);
 ReactDevTools.initialize(this.contentElement, {
 bridge: this.bridge,
 store: this.store,
 theme: usingDarkTheme ? 'dark' : 'light',
@motiz88motiz88Apr 15, 2024

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:
  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?
@hoxyqhoxyqApr 15, 2024•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?
Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.
Does CDT allow the user to override the theme? Will this honour that setting?
Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.
 });
 }

 override wasShown(): void {
 super.wasShown();
 private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
 if (!event.data) {
 return;
 }

 this.render();
 for (const listener of this.listeners) {
 listener(event.data);
 }
 }

 render(): void {
 return;
 private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
 for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
 void model.sendMessage({event, payload});
 }
 }
}

2 changes: 1 addition & 1 deletion
front_end/panels/react_devtools/react_devtools-meta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
 experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 condition: null,
 })) {
 return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
 return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
 }

 return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down

16 changes: 16 additions & 0 deletions
scripts/build/generate_html_entrypoint.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
 );
 }

 // React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
 // https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
 // Here we update the CSP header to allow workers from self
 if (entrypoint === 'rn_fusebox') {
 const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
 const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
 if (cspHeaderMatch === null) {
 throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
 }

 rewrittenTemplateContent = rewrittenTemplateContent.replace(
 cspHeaderRegex,
 '$1; worker-src \'self\' blob:'
 );
 }

 writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: use and initialize RDT Frontend in RDT panel by hoxyq · Pull Request #23 · react/react-native-devtools-frontend · GitHub
Skip to content
feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Apr 15, 2024
 Merged


feat: use and initialize RDT Frontend in RDT panel
#23
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


98 changes: 84 additions & 14 deletions
front_end/panels/react_devtools/ReactDevToolsView.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
 static instance(): ReactDevToolsViewImpl {
 if (!instance) {
 instance = new ReactDevToolsViewImpl();
 }
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
 /**
 *@description Title of the React DevTools view
 */
 title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
 private readonly wall: ReactDevToolsTypes.Wall;
 private readonly bridge: ReactDevToolsTypes.Bridge;
 private readonly store: ReactDevToolsTypes.Store;
 private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

 constructor() {
 super(i18nString(UIStrings.title));

 this.wall = {
 listen: (listener): Function => {
 this.listeners.add(listener);

 return (): void => {
 this.listeners.delete(listener);
 };
 },
 send: (event, payload): void => this.sendMessage(event, payload),
 };

 // To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
 this.bridge = ReactDevTools.createBridge(this.wall);
 this.store = ReactDevTools.createStore(this.bridge);

 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.MessageReceived,
 this.onMessage,
 this,
 );

 return instance;
 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.Initialized,
 this.initialize,
 this,
 );

 const loaderContainer = document.createElement('div');
 loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

 const loader = document.createElement('span');
 loader.classList.add('spinner');

 loaderContainer.appendChild(loader);
 this.contentElement.appendChild(loaderContainer);
 }

 private constructor() {
 super(true, true);
 private initialize(): void {
 // Remove loader
 this.contentElement.removeChildren();

 const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

 this.registerCSSFiles([ReactDevTools.CSS]);
 ReactDevTools.initialize(this.contentElement, {
 bridge: this.bridge,
 store: this.store,
 theme: usingDarkTheme ? 'dark' : 'light',
@motiz88motiz88Apr 15, 2024

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:
  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?
@hoxyqhoxyqApr 15, 2024•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?
Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.
Does CDT allow the user to override the theme? Will this honour that setting?
Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.
 });
 }

 override wasShown(): void {
 super.wasShown();
 private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
 if (!event.data) {
 return;
 }

 this.render();
 for (const listener of this.listeners) {
 listener(event.data);
 }
 }

 render(): void {
 return;
 private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
 for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
 void model.sendMessage({event, payload});
 }
 }
}

2 changes: 1 addition & 1 deletion
front_end/panels/react_devtools/react_devtools-meta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
 experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 condition: null,
 })) {
 return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
 return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
 }

 return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down

16 changes: 16 additions & 0 deletions
scripts/build/generate_html_entrypoint.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
 );
 }

 // React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
 // https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
 // Here we update the CSP header to allow workers from self
 if (entrypoint === 'rn_fusebox') {
 const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
 const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
 if (cspHeaderMatch === null) {
 throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
 }

 rewrittenTemplateContent = rewrittenTemplateContent.replace(
 cspHeaderRegex,
 '$1; worker-src \'self\' blob:'
 );
 }

 writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: use and initialize RDT Frontend in RDT panel by hoxyq · Pull Request #23 · react/react-native-devtools-frontend · GitHub
Skip to content
feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Apr 15, 2024
 Merged


feat: use and initialize RDT Frontend in RDT panel
#23
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


98 changes: 84 additions & 14 deletions
front_end/panels/react_devtools/ReactDevToolsView.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
 static instance(): ReactDevToolsViewImpl {
 if (!instance) {
 instance = new ReactDevToolsViewImpl();
 }
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
 /**
 *@description Title of the React DevTools view
 */
 title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
 private readonly wall: ReactDevToolsTypes.Wall;
 private readonly bridge: ReactDevToolsTypes.Bridge;
 private readonly store: ReactDevToolsTypes.Store;
 private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

 constructor() {
 super(i18nString(UIStrings.title));

 this.wall = {
 listen: (listener): Function => {
 this.listeners.add(listener);

 return (): void => {
 this.listeners.delete(listener);
 };
 },
 send: (event, payload): void => this.sendMessage(event, payload),
 };

 // To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
 this.bridge = ReactDevTools.createBridge(this.wall);
 this.store = ReactDevTools.createStore(this.bridge);

 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.MessageReceived,
 this.onMessage,
 this,
 );

 return instance;
 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.Initialized,
 this.initialize,
 this,
 );

 const loaderContainer = document.createElement('div');
 loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

 const loader = document.createElement('span');
 loader.classList.add('spinner');

 loaderContainer.appendChild(loader);
 this.contentElement.appendChild(loaderContainer);
 }

 private constructor() {
 super(true, true);
 private initialize(): void {
 // Remove loader
 this.contentElement.removeChildren();

 const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

 this.registerCSSFiles([ReactDevTools.CSS]);
 ReactDevTools.initialize(this.contentElement, {
 bridge: this.bridge,
 store: this.store,
 theme: usingDarkTheme ? 'dark' : 'light',
@motiz88motiz88Apr 15, 2024

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:
  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?
@hoxyqhoxyqApr 15, 2024•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?
Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.
Does CDT allow the user to override the theme? Will this honour that setting?
Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.
 });
 }

 override wasShown(): void {
 super.wasShown();
 private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
 if (!event.data) {
 return;
 }

 this.render();
 for (const listener of this.listeners) {
 listener(event.data);
 }
 }

 render(): void {
 return;
 private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
 for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
 void model.sendMessage({event, payload});
 }
 }
}

2 changes: 1 addition & 1 deletion
front_end/panels/react_devtools/react_devtools-meta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
 experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 condition: null,
 })) {
 return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
 return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
 }

 return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down

16 changes: 16 additions & 0 deletions
scripts/build/generate_html_entrypoint.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
 );
 }

 // React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
 // https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
 // Here we update the CSP header to allow workers from self
 if (entrypoint === 'rn_fusebox') {
 const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
 const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
 if (cspHeaderMatch === null) {
 throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
 }

 rewrittenTemplateContent = rewrittenTemplateContent.replace(
 cspHeaderRegex,
 '$1; worker-src \'self\' blob:'
 );
 }

 writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat: use and initialize RDT Frontend in RDT panel by hoxyq · Pull Request #23 · react/react-native-devtools-frontend · GitHub
Skip to content
feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Apr 15, 2024
 Merged


feat: use and initialize RDT Frontend in RDT panel
#23
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


98 changes: 84 additions & 14 deletions
front_end/panels/react_devtools/ReactDevToolsView.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
 static instance(): ReactDevToolsViewImpl {
 if (!instance) {
 instance = new ReactDevToolsViewImpl();
 }
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
 /**
 *@description Title of the React DevTools view
 */
 title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
 private readonly wall: ReactDevToolsTypes.Wall;
 private readonly bridge: ReactDevToolsTypes.Bridge;
 private readonly store: ReactDevToolsTypes.Store;
 private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

 constructor() {
 super(i18nString(UIStrings.title));

 this.wall = {
 listen: (listener): Function => {
 this.listeners.add(listener);

 return (): void => {
 this.listeners.delete(listener);
 };
 },
 send: (event, payload): void => this.sendMessage(event, payload),
 };

 // To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
 this.bridge = ReactDevTools.createBridge(this.wall);
 this.store = ReactDevTools.createStore(this.bridge);

 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.MessageReceived,
 this.onMessage,
 this,
 );

 return instance;
 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.Initialized,
 this.initialize,
 this,
 );

 const loaderContainer = document.createElement('div');
 loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

 const loader = document.createElement('span');
 loader.classList.add('spinner');

 loaderContainer.appendChild(loader);
 this.contentElement.appendChild(loaderContainer);
 }

 private constructor() {
 super(true, true);
 private initialize(): void {
 // Remove loader
 this.contentElement.removeChildren();

 const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

 this.registerCSSFiles([ReactDevTools.CSS]);
 ReactDevTools.initialize(this.contentElement, {
 bridge: this.bridge,
 store: this.store,
 theme: usingDarkTheme ? 'dark' : 'light',
@motiz88motiz88Apr 15, 2024

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:
  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?
@hoxyqhoxyqApr 15, 2024•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?
Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.
Does CDT allow the user to override the theme? Will this honour that setting?
Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.
 });
 }

 override wasShown(): void {
 super.wasShown();
 private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
 if (!event.data) {
 return;
 }

 this.render();
 for (const listener of this.listeners) {
 listener(event.data);
 }
 }

 render(): void {
 return;
 private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
 for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
 void model.sendMessage({event, payload});
 }
 }
}

2 changes: 1 addition & 1 deletion
front_end/panels/react_devtools/react_devtools-meta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
 experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 condition: null,
 })) {
 return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
 return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
 }

 return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down

16 changes: 16 additions & 0 deletions
scripts/build/generate_html_entrypoint.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
 );
 }

 // React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
 // https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
 // Here we update the CSP header to allow workers from self
 if (entrypoint === 'rn_fusebox') {
 const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
 const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
 if (cspHeaderMatch === null) {
 throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
 }

 rewrittenTemplateContent = rewrittenTemplateContent.replace(
 cspHeaderRegex,
 '$1; worker-src \'self\' blob:'
 );
 }

 writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: use and initialize RDT Frontend in RDT panel by hoxyq · Pull Request #23 · react/react-native-devtools-frontend · GitHub
Skip to content
feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Apr 15, 2024
 Merged


feat: use and initialize RDT Frontend in RDT panel
#23
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


98 changes: 84 additions & 14 deletions
front_end/panels/react_devtools/ReactDevToolsView.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
 static instance(): ReactDevToolsViewImpl {
 if (!instance) {
 instance = new ReactDevToolsViewImpl();
 }
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
 /**
 *@description Title of the React DevTools view
 */
 title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
 private readonly wall: ReactDevToolsTypes.Wall;
 private readonly bridge: ReactDevToolsTypes.Bridge;
 private readonly store: ReactDevToolsTypes.Store;
 private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

 constructor() {
 super(i18nString(UIStrings.title));

 this.wall = {
 listen: (listener): Function => {
 this.listeners.add(listener);

 return (): void => {
 this.listeners.delete(listener);
 };
 },
 send: (event, payload): void => this.sendMessage(event, payload),
 };

 // To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
 this.bridge = ReactDevTools.createBridge(this.wall);
 this.store = ReactDevTools.createStore(this.bridge);

 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.MessageReceived,
 this.onMessage,
 this,
 );

 return instance;
 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.Initialized,
 this.initialize,
 this,
 );

 const loaderContainer = document.createElement('div');
 loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

 const loader = document.createElement('span');
 loader.classList.add('spinner');

 loaderContainer.appendChild(loader);
 this.contentElement.appendChild(loaderContainer);
 }

 private constructor() {
 super(true, true);
 private initialize(): void {
 // Remove loader
 this.contentElement.removeChildren();

 const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

 this.registerCSSFiles([ReactDevTools.CSS]);
 ReactDevTools.initialize(this.contentElement, {
 bridge: this.bridge,
 store: this.store,
 theme: usingDarkTheme ? 'dark' : 'light',
@motiz88motiz88Apr 15, 2024

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:
  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?
@hoxyqhoxyqApr 15, 2024•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?
Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.
Does CDT allow the user to override the theme? Will this honour that setting?
Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.
 });
 }

 override wasShown(): void {
 super.wasShown();
 private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
 if (!event.data) {
 return;
 }

 this.render();
 for (const listener of this.listeners) {
 listener(event.data);
 }
 }

 render(): void {
 return;
 private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
 for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
 void model.sendMessage({event, payload});
 }
 }
}

2 changes: 1 addition & 1 deletion
front_end/panels/react_devtools/react_devtools-meta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
 experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 condition: null,
 })) {
 return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
 return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
 }

 return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down

16 changes: 16 additions & 0 deletions
scripts/build/generate_html_entrypoint.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
 );
 }

 // React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
 // https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
 // Here we update the CSP header to allow workers from self
 if (entrypoint === 'rn_fusebox') {
 const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
 const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
 if (cspHeaderMatch === null) {
 throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
 }

 rewrittenTemplateContent = rewrittenTemplateContent.replace(
 cspHeaderRegex,
 '$1; worker-src \'self\' blob:'
 );
 }

 writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat: use and initialize RDT Frontend in RDT panel by hoxyq · Pull Request #23 · react/react-native-devtools-frontend · GitHub
Skip to content
feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Apr 15, 2024
 Merged


feat: use and initialize RDT Frontend in RDT panel
#23
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


98 changes: 84 additions & 14 deletions
front_end/panels/react_devtools/ReactDevToolsView.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
 static instance(): ReactDevToolsViewImpl {
 if (!instance) {
 instance = new ReactDevToolsViewImpl();
 }
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
 /**
 *@description Title of the React DevTools view
 */
 title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
 private readonly wall: ReactDevToolsTypes.Wall;
 private readonly bridge: ReactDevToolsTypes.Bridge;
 private readonly store: ReactDevToolsTypes.Store;
 private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

 constructor() {
 super(i18nString(UIStrings.title));

 this.wall = {
 listen: (listener): Function => {
 this.listeners.add(listener);

 return (): void => {
 this.listeners.delete(listener);
 };
 },
 send: (event, payload): void => this.sendMessage(event, payload),
 };

 // To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
 this.bridge = ReactDevTools.createBridge(this.wall);
 this.store = ReactDevTools.createStore(this.bridge);

 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.MessageReceived,
 this.onMessage,
 this,
 );

 return instance;
 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.Initialized,
 this.initialize,
 this,
 );

 const loaderContainer = document.createElement('div');
 loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

 const loader = document.createElement('span');
 loader.classList.add('spinner');

 loaderContainer.appendChild(loader);
 this.contentElement.appendChild(loaderContainer);
 }

 private constructor() {
 super(true, true);
 private initialize(): void {
 // Remove loader
 this.contentElement.removeChildren();

 const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

 this.registerCSSFiles([ReactDevTools.CSS]);
 ReactDevTools.initialize(this.contentElement, {
 bridge: this.bridge,
 store: this.store,
 theme: usingDarkTheme ? 'dark' : 'light',
@motiz88motiz88Apr 15, 2024

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:
  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?
@hoxyqhoxyqApr 15, 2024•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?
Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.
Does CDT allow the user to override the theme? Will this honour that setting?
Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.
 });
 }

 override wasShown(): void {
 super.wasShown();
 private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
 if (!event.data) {
 return;
 }

 this.render();
 for (const listener of this.listeners) {
 listener(event.data);
 }
 }

 render(): void {
 return;
 private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
 for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
 void model.sendMessage({event, payload});
 }
 }
}

2 changes: 1 addition & 1 deletion
front_end/panels/react_devtools/react_devtools-meta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
 experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 condition: null,
 })) {
 return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
 return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
 }

 return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down

16 changes: 16 additions & 0 deletions
scripts/build/generate_html_entrypoint.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
 );
 }

 // React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
 // https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
 // Here we update the CSP header to allow workers from self
 if (entrypoint === 'rn_fusebox') {
 const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
 const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
 if (cspHeaderMatch === null) {
 throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
 }

 rewrittenTemplateContent = rewrittenTemplateContent.replace(
 cspHeaderRegex,
 '$1; worker-src \'self\' blob:'
 );
 }

 writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat: use and initialize RDT Frontend in RDT panel by hoxyq · Pull Request #23 · react/react-native-devtools-frontend · GitHub
Skip to content
feat: use and initialize RDT Frontend in RDT panel#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

hoxyq
merged 1 commit into

from

Apr 15, 2024
 Merged


feat: use and initialize RDT Frontend in RDT panel
#23
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


98 changes: 84 additions & 14 deletions
front_end/panels/react_devtools/ReactDevToolsView.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,30 +3,100 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import * as i18n from '../../core/i18n/i18n.js';
import * as UI from '../../ui/legacy/legacy.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as ReactDevTools from '../../third_party/react-devtools/react-devtools.js';

let instance: ReactDevToolsViewImpl;
import type * as ReactDevToolsTypes from '../../third_party/react-devtools/react-devtools.js';
import type * as Common from '../../core/common/common.js';

export class ReactDevToolsViewImpl extends UI.Widget.VBox {
 static instance(): ReactDevToolsViewImpl {
 if (!instance) {
 instance = new ReactDevToolsViewImpl();
 }
import {Events, ReactDevToolsModel, type EventTypes} from './ReactDevToolsModel.js';

const UIStrings = {
 /**
 *@description Title of the React DevTools view
 */
 title: 'React DevTools',
};
const str_ = i18n.i18n.registerUIStrings('panels/react_devtools/ReactDevToolsView.ts', UIStrings);
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

export class ReactDevToolsViewImpl extends UI.View.SimpleView {
 private readonly wall: ReactDevToolsTypes.Wall;
 private readonly bridge: ReactDevToolsTypes.Bridge;
 private readonly store: ReactDevToolsTypes.Store;
 private readonly listeners: Set<ReactDevToolsTypes.WallListener> = new Set();

 constructor() {
 super(i18nString(UIStrings.title));

 this.wall = {
 listen: (listener): Function => {
 this.listeners.add(listener);

 return (): void => {
 this.listeners.delete(listener);
 };
 },
 send: (event, payload): void => this.sendMessage(event, payload),
 };

 // To use the custom Wall we've created, we need to also create our own "Bridge" and "Store" objects.
 this.bridge = ReactDevTools.createBridge(this.wall);
 this.store = ReactDevTools.createStore(this.bridge);

 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.MessageReceived,
 this.onMessage,
 this,
 );

 return instance;
 SDK.TargetManager.TargetManager.instance().addModelListener(
 ReactDevToolsModel,
 Events.Initialized,
 this.initialize,
 this,
 );

 const loaderContainer = document.createElement('div');
 loaderContainer.setAttribute('style', 'display: flex; flex: 1; justify-content: center; align-items: center');

 const loader = document.createElement('span');
 loader.classList.add('spinner');

 loaderContainer.appendChild(loader);
 this.contentElement.appendChild(loaderContainer);
 }

 private constructor() {
 super(true, true);
 private initialize(): void {
 // Remove loader
 this.contentElement.removeChildren();

 const usingDarkTheme = window.matchMedia('(prefers-color-scheme: dark)').matches;

 this.registerCSSFiles([ReactDevTools.CSS]);
 ReactDevTools.initialize(this.contentElement, {
 bridge: this.bridge,
 store: this.store,
 theme: usingDarkTheme ? 'dark' : 'light',
@motiz88motiz88Apr 15, 2024

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits - can be filed as followup tasks IMO:
  1. Is this reactive to theme changes?
  2. Does CDT allow the user to override the theme? Will this honour that setting?
@hoxyqhoxyqApr 15, 2024•

edited

Loading

Copy link


Copy Markdown

Author
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reactive to theme changes?
Nope, it doesn't, unfortunately. I am keeping this in T185412086, because we can reuse it for browser extension.
Does CDT allow the user to override the theme? Will this honour that setting?
Yes, I've specified using dark theme in my Chrome and my Fusebox window is opened in dark mode across different reloads.
 });
 }

 override wasShown(): void {
 super.wasShown();
 private onMessage(event: Common.EventTarget.EventTargetEvent<EventTypes[Events.MessageReceived]>): void {
 if (!event.data) {
 return;
 }

 this.render();
 for (const listener of this.listeners) {
 listener(event.data);
 }
 }

 render(): void {
 return;
 private sendMessage(event: string, payload?: ReactDevToolsTypes.MessagePayload): void {
 for (const model of SDK.TargetManager.TargetManager.instance().models(ReactDevToolsModel, {scoped: true})) {
 void model.sendMessage({event, payload});
 }
 }
}

2 changes: 1 addition & 1 deletion
front_end/panels/react_devtools/react_devtools-meta.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ UI.ViewManager.registerViewExtension({
 experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 condition: null,
 })) {
 return Module.ReactDevToolsView.ReactDevToolsViewImpl.instance();
 return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
 }

 return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
Expand Down

16 changes: 16 additions & 0 deletions
scripts/build/generate_html_entrypoint.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,5 +46,21 @@ for (const entrypoint of entrypoints) {
 );
 }

 // React DevTools uses Web Workers API for parsing hook names and uploading large tracing files
 // https://github.com/facebook/react/blob/fd35655fae9f88284e01754cadb0707abaca795b/packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js
 // Here we update the CSP header to allow workers from self
 if (entrypoint === 'rn_fusebox') {
 const cspHeaderRegex = /(?<=<meta http-equiv="Content-Security-Policy" content=")(.*)(?=">)/;
 const cspHeaderMatch = rewrittenTemplateContent.match(cspHeaderRegex);
 if (cspHeaderMatch === null) {
 throw new Error('Couldn\'t find CSP header for rn_fusebox entrypoint: this can break React DevTools panel');
 }

 rewrittenTemplateContent = rewrittenTemplateContent.replace(
 cspHeaderRegex,
 '$1; worker-src \'self\' blob:'
 );
 }

 writeIfChanged(path.join(outDirectory, `${entrypoint}.html`), rewrittenTemplateContent);
}