Uh oh!
There was an error while loading. Please reload this page.
Add React Native doctor blog post - #1420
Conversation
lucasbento
commented
Oct 21, 2019
@rickhanlonii@thymikee please give a review. |
Deploy preview for react-native ready! Built with commit 20a1878 https://deploy-preview-1420--react-native.netlify.com Changes to Thank you for your contributions. |
rickhanlonii
left a comment
There was a problem hiding this comment.
Looks good! I left a few suggestions, and what do you think about mentioning that doctor is a standard command with other tools that provide it like homebrew? As it stands, it can be read as if to say we're inventing this but in actuality it's building on prior art
Also, to add some more content and because people would be curious, how about adding a section that lists all of the checks we currently do and why they're necessary for react native?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lucasbento
commented
Oct 22, 2019
@rickhanlonii: thank you for the review, gonna work on the changes! |
lucasbento
commented
Oct 30, 2019
@rickhanlonii: changes done!
I think this is good, I tried adding it but it's a lot of repetition, such as: So I'm not so sure about it. |
lucasbento
commented
Oct 30, 2019
Also added a video to showcase the command, please let me know your thoughts 😄 cc @thymikee |
rickhanlonii
commented
Oct 30, 2019
I was thinking basically listing the same info that is in the video: So: What checks do we runWe check for the basics such as:
We'll also run checks for the Android environment:
and the iOS environment:
|
rickhanlonii
commented
Oct 30, 2019
@lucasbento thee video looks awesome, great work 🎉 |
lucasbento
commented
Oct 30, 2019
@rickhanlonii thanks! I will add those things tomorrow morning. |
thymikee
left a comment
There was a problem hiding this comment.
Looking good! Left some suggestions to think about
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lucasbento
commented
Nov 4, 2019
@rickhanlonii@thymikee: all done, please check again :D |
thymikee
left a comment
There was a problem hiding this comment.
LGTM 👍 Let's keep in mind that we'll need to release the CLI v3 first
rickhanlonii
left a comment
There was a problem hiding this comment.
Look great, this is so exciting!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| ## Try it now | ||
| The `doctor` command is available as a part of React Native 0.62. However, you can try it without upgrading yet: |
There was a problem hiding this comment.
Technically 0.61 has it already, should we update that or maybe we want to get people a bit more excited about next major?
There was a problem hiding this comment.
I'm honestly not sure about this.
@rickhanlonii what do you think?
cpojer
commented
Nov 19, 2019
Are we ready to launch this? |

This PR is to add the React Native doctor blog post announcement.
TODO
react-native-community/cliv3 (dependent on feat: run npx from JS app dir react-native-community/cli#824)