Uh oh!
There was an error while loading. Please reload this page.
Update docs for https://github.com/facebook/react-native/pull/17747 - #156
Update docs for https://github.com/facebook/react-native/pull/17747#156msand wants to merge 1 commit into
Conversation
react-native-bot
commented
Jan 26, 2018
Deploy preview for react-native ready! Built with commit bba7a94 |
hramos
commented
Jan 26, 2018
Thanks, let's come back to this when the PR is merged. |
Wait how does this commit makes sense without updating build.gradle of RN simultaneously? This is changing
and
But if you look at the relevant part of build.gradle the numbers there are still are So I think merging this PR as it is will only create confusion, because the docs will suggest Android tools that have a mismatch with what RN actually uses. Edit: The other PR at react/react-native@43fdacc#diff-22bd14e85636c66689f1a94a02a56b22R4 still has mismatch with this doc PR (26.0.2 vs 27.0.3). |
@hey99xx I had updated and force-pushed to the branch in the PR in RN, and am waiting for more feedback react/react-native#17747 (comment) |
msand
commented
Feb 8, 2018
But, the instructions about build tool versions could probably be removed completely, as the new gradle version will pick one itself depending on compatibility. |
cpojer
commented
Feb 7, 2019
It seems like this is outdated now and we'll need a new PR with the latest versions for everything. Sorry that it took so long to get back to this. |
Update docs for react/react-native#17747