Skip to content

Adding configureNext.onAnimationDidFail callback on LayoutAnimation - #2136

Merged
cpojer merged 4 commits into
react:masterfrom
gedeagas:feature/layoutanimation
Sep 29, 2020
Merged

Adding configureNext.onAnimationDidFail callback on LayoutAnimation#2136
cpojer merged 4 commits into
react:masterfrom
gedeagas:feature/layoutanimation

Conversation

@gedeagas

@gedeagasgedeagas commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

This PR updates the documentation to reflect the (pending) changes on LayoutAnimation configureNext.onAnimationDidFail callback.

See here for references react/react-native@777957c

@react-native-bot

react-native-bot commented Aug 11, 2020

Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit dc2d5d2

https://deploy-preview-2136--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@gedeagas

Copy link
Copy Markdown
ContributorAuthor

@rachelnabors @Simek Hi guys, since this callback is fabric only and probably not called from the native side in non-fabric I am curious about the strategy here. how do you guys approach on documenting fabric only API with noop for non-fabric?

@SimekSimek added the Wait on future Release This indicates a PR that updates the doc to match a future release. label Aug 12, 2020
@SimekSimek changed the title Adding configureNext.onAnimationDidFail callback on LayoutAnimation ( Future Release )Adding configureNext.onAnimationDidFail callback on LayoutAnimationAug 12, 2020

@cpojercpojer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpojer
cpojer merged commit 3e5b9e4 into react:masterSep 29, 2020
slorber pushed a commit to react-native-website-migration/react-native-website that referenced this pull request Oct 9, 2020
* Update introduction.md (react#2181)
Hooks were introduced in React Native 0.59, not 0.58.
* adding snack player instead of images for flexbox (react#2171)
* adding snack player instead of images for flexbox
* chore: revert yarn.lock
* minor changes and improvements, prettier run on examples
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* UI & UX Design with InputAccessoryView (react#2183)
* UI Design with InputAccessoryView * Update inputaccessoryview.md
* small tweaks
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* update TextInput example, refs react#2187
* add TOC and improve formatting on the Android publishing page
* Modernize code examples in the direct manipulation section (react#2189)
* Modernize code examples in the direct manipulation section.
* small code tweaks/fixes + run code through Prettier
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* update Alert API page, include iOS specific functions from deprecated AlertIOS (react#2184)
Thanks for this one, @Simek!
* Update getting-started.md (react#2194)
Python2 & Python3 are both compatible
* fix homepage showcase app list graphical issue (react#2185)
Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>
* docs: add matrix to transform (react#2197)
* Bump decompress from 4.2.0 to 4.2.1 in /website (react#2200)
Bumps [decompress](https://github.com/kevva/decompress) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/kevva/decompress/releases)
- [Commits](kevva/decompress@v4.2.0...v4.2.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Typo fix (react#2202)
* fixesreact#2201, delete duplicated TOC, add note about removal to TabBarIOS pages
* docs: update deprecated usage of findNodeHandle in measureLayout (react#2199)
* docs: update deprecated usage of findNodeHandle in measureLayout
* minor text and Snack tweaks, prettier run
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* bump alex and node-fetch, fix new alex warning
* typo fix
* TextInput: Add `onPressIn` and `onPressOut` docs (react#2205)
Original summary by @yungsters in [1b994f9](react/react-native@b7b0e23):
Introduces support for `onPressIn` and `onPressOut` on the `TextInput` component.
This makes it possible to add visual feedback when users touch interact with `TextInput` components.
* Fix typos (react#2204)
* link out-of-tree platforms, add macOS platform, unify dashes on homepage (react#2186)
* link out-of-tree platforms, add macOS, unify dashes on homepage
* revert dashes changes
* update SectionList page, extract ViewToken, add labels (react#2191)
* update TextInput press callbacks type, refs react#2205
* Added workarounds for TextInputs (react#2203)
* Added workarounds for TextInputs
* provide info on the focus management using <Modal>
* small text tweaks
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* update Text page and add types, add LayoutEvent object page (react#2209)
* Incorrect command (react#2207)
https://github.com/react-native-community/cli/blob/master/docs/commands.md#run-android
`--variant [string]`
* Updated ScrollView `disableIntervalMomentum` doc. (react#2211)
* Remove announcement banner. (react#2213)
* Docs: Removing `onTextInput` prop from TextInput (react#2216)
* Removing `onTextInput` prop from TextInput doc.
* Removing `onTextInput` prop from TextInput on version 0.62 & 0.63.
* Signing not under General for me (react#2214)
* Update running-on-simulator-ios.md (react#2220)
We have to specify the generation for the iPhone SE simulator.
* [DOC] fixed errata in image doc (react#2221)
* Add documentation for Hermes sampling profiler (react#2159)
Co-authored-by: Saphal Patro <31125345+saphal1998@users.noreply.github.com>
Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>
Co-authored-by: Saphal Patro <saphal1998@gmail.com>
* Adding Android NDK Installation Guide (react#2225)
* Docs: Integration with android fragment (react#2217)
Co-authored-by: Sebastien Bailouni <sbailouni@gmail.com>
* Add new option to ActionSheetIOS called disabledButtonsIndices (react#1898)
* Adding configureNext.onAnimationDidFail callback on LayoutAnimation (react#2136)
Co-authored-by: Christoph Nakazawa <cpojer@fb.com>
* Added Coinbase to showcase (react#2227)
* Added Coinbase to showcase
* Add Coinbase icon
* 0.63.3 release - update Pressable delay (react#2226)
* Improved README.md (react#2233)
* fix typo (react#2232)
* fix typo
fixes typo in "Using Custom Path Aliases with TypeScript" section (configure -> configuring)
* sentence rewrite
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* Add Shopify and Tableau to showcase (react#2228)
* Add Shopify in showcase
* Add Shopify icon
* Add Tableau to showcase
* Add tableau image asset
* Update Tableau icon
* updated debugging.md (react#2241)
fixed a typo in unhandled error
* Update appregistry.md (react#2246)
* Update out-of-tree-platforms.md (react#2243)
* Remove unnecessary python dependency (react#2250)
Python is not required anymore on windows platform. The only binary addon for react-native project are some deps of `ws`, [which now have prebuilt binary and are optional](https://github.com/websockets/ws#opt-in-for-performance-and-spec-compliance). Tested on a brand new windows 10 image with only node installed, the initiating process goes well.
* Update network.md to show android non ssl block (react#2245)
* Update network.md to show android non ssl block
added note for android's android:usesCleartextTraffic flag in manifest file to allow non ssl encrypted networking - to go alongside the existing note for ios.
* small text tweaks
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* remove link in native-modules-ios (react#2244)
Co-authored-by: luism3861 <eduardo_media@fragua.com.mx>
* Update textinput.md (react#2249)
* Update textinput.md
This will make it more clear for beginners who are trying to use onBlur to do a final action on their textInput's text value.
* formatting, text tweaks
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
* revert change to Netlify config due to V2 test merge
Co-authored-by: Georgios Kotziabassis <kotziabassis@gmail.com>
Co-authored-by: Muhammad Saeed <37156636+Stringsaeed@users.noreply.github.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Mojtaba Vandaei <62926492+mojvan@users.noreply.github.com>
Co-authored-by: Steven Luscher <steveluscher@users.noreply.github.com>
Co-authored-by: Pratik Khandelwal <prkhandelwal@hotmail.com>
Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>
Co-authored-by: Jesse Katsumata <jesse.katsumata@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joe Bernard <joe@joebernard.com>
Co-authored-by: Thibault Malbranche <thibault.malbranche@epitech.eu>
Co-authored-by: Luis Miguel Alvarado <luismiguel1730@gmail.com>
Co-authored-by: Pramod Kotipalli <p13i@users.noreply.github.com>
Co-authored-by: Madd.is <github@madd.is>
Co-authored-by: Kirill <laikisounds@gmail.com>
Co-authored-by: Ashwin Mothilal <ashwin.mothilal2124@gmail.com>
Co-authored-by: Christoph Nakazawa <cpojer@fb.com>
Co-authored-by: captDaylight <paul.christophe6@gmail.com>
Co-authored-by: ppichier <pierantonio.pichierri@gmail.com>
Co-authored-by: Varunendra Pratap Singh <vpsingh016@gmail.com>
Co-authored-by: Jessie Anh Nguyen <47696418+jessieAnhNguyen@users.noreply.github.com>
Co-authored-by: Saphal Patro <31125345+saphal1998@users.noreply.github.com>
Co-authored-by: Saphal Patro <saphal1998@gmail.com>
Co-authored-by: Agastya Darma <gedeagas22@gmail.com>
Co-authored-by: Steven Martin <stevenisekimartin@gmail.com>
Co-authored-by: Sebastien Bailouni <sbailouni@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Jessica Lin <jlin2700@gmail.com>
Co-authored-by: Vishal Vishwakarma <56310842+vishalvishw10@users.noreply.github.com>
Co-authored-by: Adam Hunter <arhunter@gmail.com>
Co-authored-by: Jessica Lin <jplin@fb.com>
Co-authored-by: Ashish Shakya <41261918+Ashish1101@users.noreply.github.com>
Co-authored-by: Sunny Luo <sunnylqm@gmail.com>
Co-authored-by: Alexander Sklar <asklar@microsoft.com>
Co-authored-by: s-maurice <51819025+s-maurice@users.noreply.github.com>
Co-authored-by: luism3861 <36824170+luism3861@users.noreply.github.com>
Co-authored-by: luism3861 <eduardo_media@fragua.com.mx>
Co-authored-by: Ralph Maamari <ralphpal@hotmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedWait on future ReleaseThis indicates a PR that updates the doc to match a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gedeagas@react-native-bot@cpojer@Simek@facebook-github-bot