Skip to content

website: add required labels TextInput - #2708

Merged
Simek merged 3 commits into
react:masterfrom
luism3861:add/required-labels-textinput
Jul 30, 2021
Merged

website: add required labels TextInput #2708
Simek merged 3 commits into
react:masterfrom
luism3861:add/required-labels-textinput

Conversation

@luism3861

@luism3861luism3861 commented Jul 28, 2021

Copy link
Copy Markdown
Contributor

this PR add required labels for specific platform, little changes in style examples, and fix broken link. additional useEffect autoFocus property.

cc: @Simek

@luism3861luism3861 changed the title website: add required labels iOS and Androidwebsite: add required labels TextInput Jul 28, 2021
@netlify

netlifyBot commented Jul 28, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: acbbfae

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/6103855a28a18400071df717

😎 Browse the preview: https://deploy-preview-2708--react-native.netlify.app

@Simek

Copy link
Copy Markdown
Collaborator

Hi @luism3861, thank you so much for the update, great work!

One more thing I want to ask you in this PR is to remove the Platform and Required columns from table (afaik TextInput do not have any required field so removing the column without any other changes could be fine, usually required field needs a special label and move to the top of the props list). When we convert page to the labels we usually also remove those columns:

Untitledx

Additionally, if you want, you can add Default column, for the props with default value, as seen for example in here:

But this can also be made in the separate PR, so please choose the resolution as it fit you. 🙂

@luism3861

Copy link
Copy Markdown
ContributorAuthor

Hi @luism3861, thank you so much for the update, great work!

One more thing I want to ask you in this PR is to remove the Platform and Required columns from table (afaik TextInput do not have any required field so removing the column without any other changes could be fine, usually required field needs a special label and move to the top of the props list). When we convert page to the labels we usually also remove those columns:

Untitledx

Additionally, if you want, you can add Default column, for the props with default value, as seen for example in here:

But this can also be made in the separate PR, so please choose the resolution as it fit you. 🙂

hi @Simek you're right i forgot delete Platform and Required my last commit has this change, about another Default column i try to send a new PR with this :), thanks!.

@SimekSimek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luism3861 Thank you for the review updates and working on the labels in the first place! 👍

@Simek
Simek merged commit f40653d into react:masterJul 30, 2021
@SimekSimek mentioned this pull request Jul 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@luism3861@Simek@facebook-github-bot