Skip to content

Iterating on Fabric Architecture docs - #2895

Merged
lunaleaps merged 4 commits into
react:fabric-architecturefrom
lunaleaps:lunaleaps-fabric-architecture
Dec 22, 2021
Merged

Iterating on Fabric Architecture docs#2895
lunaleaps merged 4 commits into
react:fabric-architecturefrom
lunaleaps:lunaleaps-fabric-architecture

Conversation

@lunaleaps

@lunaleapslunaleaps commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Working on:

  • Editing the opening sections to explain "what this doc will tell you and why you might care" a little better (re: adding context that these docs are discussing about the new architecture Fabric and link to the "Fabric Page")
  • Split up "rendering-implementation" into 3 sections
  • Added a 1-line summary of each doc

@lunaleapslunaleaps changed the title Lunaleaps fabric architectureIterating on Fabric Architecture docsDec 21, 2021
@lunaleaps
lunaleapsforce-pushed the lunaleaps-fabric-architecture branch from ea170b9 to f0d0d3bCompareDecember 21, 2021 23:19
@lunaleaps
lunaleaps changed the base branch from fabric-architecture to mainDecember 22, 2021 00:40
@lunaleapslunaleaps reopened this Dec 22, 2021
@lunaleaps

Copy link
Copy Markdown
ContributorAuthor

Hmm I'm wondering how to trigger netlify on this, I might close and re-open this PR?

@Simek

Copy link
Copy Markdown
Collaborator

Hmm I'm wondering how to trigger netlify on this, I might close and re-open this PR?

Currently deploy preview is setup only to work on the PRs targeting main branch. I cannot recall why this was setup in that way.

Same problem affects #2882, so maybe we should update the preview deploy workflow?

@lunaleaps
lunaleaps changed the base branch from main to fabric-architectureDecember 22, 2021 18:02
@lunaleaps
lunaleaps merged commit 00d33df into react:fabric-architectureDec 22, 2021
@lunaleaps
lunaleaps deleted the lunaleaps-fabric-architecture branch December 22, 2021 18:51
lunaleaps pushed a commit that referenced this pull request Dec 22, 2021
* Add some intro to 'Render,Commit, and Mount'
* Update Fabric Render -> Fabric Renderer
* Split out rendering-implementation into three different docs
* Create a sentence callout for each
sammy-SC added a commit that referenced this pull request Dec 23, 2021
#2892)
* Initial draft of new Architecture Section including docs on how React Native's renderer works
* linting language
* changing the IA for architecture section
* update arc overview
* Iterating on Fabric Architecture docs (#2895)
* Add some intro to 'Render,Commit, and Mount'
* Update Fabric Render -> Fabric Renderer
* Split out rendering-implementation into three different docs
* Create a sentence callout for each
* Fix broken links
* Formatting for view-flattening (#2899)
* Updates to xplat-implementation, re: glossary links and fabric terms (#2898)
* Refactor how we layout the scenarios (#2897)
* Format render-pipeline.md (#2900)
* Format fabric-renderer.md (#2901)
* Format fabric-renderer.md
* Anchor fabric-renderer in time
* Add images to Fabric Deep Dive (#2902)
* Resize images in threading model section (#2903)
* Fabric-rendering word tweaks
* Cut a 0.66 version of the architecture and update header
* Word tweaks
Co-authored-by: Luna <luwe@fb.com>
Co-authored-by: Samuel Susla <samuel.susla@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lunaleaps@Simek@facebook-github-bot