Skip to content

Add TypeScript support in New Architecture/Codegen - #3036

Merged
charlesbdudley merged 5 commits into
react:mainfrom
charlesbdudley:main
Apr 13, 2022
Merged

Add TypeScript support in New Architecture/Codegen#3036
charlesbdudley merged 5 commits into
react:mainfrom
charlesbdudley:main

Conversation

@charlesbdudley

@charlesbdudleycharlesbdudley commented Mar 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Updated the documentation to specify that TypeScript spec files are supported, with examples for both TurboModules and Fabric Components

@netlify

netlifyBot commented Mar 29, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

NameLink
🔨 Latest commit6f57418
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/6257312855f5ef0009e63fee
😎 Deploy Previewhttps://deploy-preview-3036--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cipolleschi
cipolleschi reviewed Mar 29, 2022
View reviewed changes

@cipolleschicipolleschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! 👏 I'm excited because it will help us also in other pieces of doc work we are carrying on.

I left a few suggestions here and there to improve homogeneity of the documentation and clarity, plus a question about TurboModules types.

Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
cortinico
cortinico reviewed Mar 29, 2022
View reviewed changes

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @charlesbdudley 👍

@Titozzz might have some opinions to share on this as well

Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
Comment threaddocs/new-architecture-library-intro.md Outdated
cipolleschi
cipolleschi reviewed Mar 29, 2022
View reviewed changes
Comment threaddocs/new-architecture-library-intro.md Outdated
charlesbdudley
charlesbdudley commented Mar 29, 2022
View reviewed changes
Comment threaddocs/new-architecture-library-intro.md Outdated
@charlesbdudleycharlesbdudley changed the title [WIP] Add TypeScript support in New Architecture/CodegenAdd TypeScript support in New Architecture/CodegenMar 31, 2022
cortinico
cortinico approved these changes Apr 13, 2022
View reviewed changes

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Accepting to unblock you

Comment threadwebsite/core/TabsConstants.js Outdated
@charlesbdudley
charlesbdudley merged commit 3844965 into react:mainApr 13, 2022
@cortinicocortinico mentioned this pull request Apr 14, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschicipolleschicipolleschi left review comments
@cortinicocortinicocortinico approved these changes

Assignees

No one assigned

Labels

CLA Signedp: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charlesbdudley@cortinico@cipolleschi@facebook-github-bot