Uh oh!
There was an error while loading. Please reload this page.
update custom webview example to use RNC webview - #3069
Merged
Conversation
jazibjafri
commented
Apr 11, 2022
ContributorAuthor
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cortinico
approved these changes
Apr 11, 2022
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, just adding a note to clarify that the external lib is actually 1st party recommended.
| @@ -9,28 +9,30 @@ Before you do this, you should be familiar with the concepts in [native UI compo | |||
Contributor
There was a problem hiding this comment.
I would add a note like:
:::info
The React Native WebView component has been moved under `react-native-community/react-native-webview` as part of the [lean core effort](https://github.com/facebook/react-native/issues/23313).
That is the recommended way to use WebView in React Native as of today. You should not use the [WebView](https://reactnative.dev/docs/0.61/webview) component as that was deprecated and removed from React Native. :::
Simek
reviewed
Apr 11, 2022
Uh oh!
There was an error while loading. Please reload this page.
Simek
reviewed
Apr 12, 2022
Uh oh!
There was an error while loading. Please reload this page.
Simek
approved these changes
Apr 12, 2022
Simek
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the updates! Let's ship this improvement! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates java code in custom-webview example to use react-native-community/react-native-webview instead of deprecated WebView
Related to this discussion