Skip to content

Add Kotlin code for "Communication Android" documentation - #3070

Merged
cortinico merged 4 commits into
react:mainfrom
junaidn:communication-android
Apr 13, 2022
Merged

Add Kotlin code for "Communication Android" documentation #3070
cortinico merged 4 commits into
react:mainfrom
junaidn:communication-android

Conversation

@junaidn

@junaidnjunaidn commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

This PR includes:
Sample code of Kotlin for docs/communication-android doc.

@facebook-github-bot

facebook-github-bot commented Apr 11, 2022

Copy link
Copy Markdown

Hi @junaidn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify

netlifyBot commented Apr 11, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

NameLink
🔨 Latest commit6be7605
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/625663af77e7770009b018ce
😎 Deploy Previewhttps://deploy-preview-3070--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@facebook-github-bot

facebook-github-bot commented Apr 11, 2022

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@junaidn

junaidn commented Apr 11, 2022

Copy link
Copy Markdown
ContributorAuthor

@cortinico@ShikaSD@mdvacca

cortinico
cortinico reviewed Apr 11, 2022
View reviewed changes

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of nits 👍 Looks good overall

Comment threaddocs/communication-android.md Outdated
override fun getLaunchOptions(): Bundle {
val initialProperties = Bundle()
val imageList =
ArrayList(listOf("http://foo.com/bar1.png", "http://foo.com/bar2.png"))

@cortinicocortinicoApr 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use arrayListOf here:
https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/array-list-of.html

@junaidnjunaidnApr 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment threaddocs/communication-android.md Outdated
val initialProperties = Bundle()
val imageList =
ArrayList(listOf("http://foo.com/bar1.png", "http://foo.com/bar2.png"))
initialProperties.putStringArrayList("images", imageList)

@cortinicocortinicoApr 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword to:

val initialProperties =Bundle().apply {
putStringArrayList("images", imageList)
}

@junaidnjunaidnApr 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment threaddocs/communication-android.md Outdated
Comment on lines +108 to +109
var imageList: ArrayList<String> =
ArrayList<String>(listOf("http://foo.com/bar3.png", "http://foo.com/bar4.png"))

@cortinicocortinicoApr 11, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@junaidnjunaidnApr 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@junaidn
junaidn requested a review from cortinicoApril 12, 2022 06:15
cortinico
cortinico approved these changes Apr 12, 2022
View reviewed changes

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small nit. Other than that, LGTM 👍

Comment threaddocs/communication-android.md Outdated
@junaidn@cortinico
Update docs/communication-android.md
6be7605
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
@cortinico
cortinico merged commit 751c48c into react:mainApr 13, 2022
@cortinico

cortinico commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

Thansk for doing this @junaidn 🙏

@cortinicocortinico mentioned this pull request Apr 13, 2022
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@junaidn@facebook-github-bot@cortinico