Uh oh!
There was an error while loading. Please reload this page.
Add Kotlin to docs/new-architecture-library-intro - #3116
Merged
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cortinico
self-requested a review
May 13, 2022 15:26
| ```kotlin | ||
| fun receiveCommand( | ||
| view: ReactMapDrawerView?, commandId: String?, @Nullable args: ReadableArray? |
Contributor
There was a problem hiding this comment.
Suggested change
| view: ReactMapDrawerView?, commandId: String?, @Nullable args: ReadableArray? | |
| view: ReactMapDrawerView?, commandId: String?, args: ReadableArray? |
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+574
to
+576
| if (args == null) { | ||
| break | ||
| } |
Contributor
There was a problem hiding this comment.
Have you tested this code? :)
Comment on lines
+577
to
+578
| val region: ReadableMap = args.getMap(0) | ||
| val durationMs: Int = args.getInt(1) |
Contributor
There was a problem hiding this comment.
I would just wrap this inside an if (args != null) block
cortinico
commented
May 13, 2022
Contributor
Thanks for sendign this over @mbharadwajfb 🙏 There are a couple of things to fix but we're good to go after this |
mbharadwajfb
marked this pull request as draft
May 16, 2022 10:56
mbharadwajfb
commented
May 16, 2022
ContributorAuthor
Code review fixes |
mbharadwajfb
marked this pull request as ready for review
May 16, 2022 11:20
cortinico
approved these changes
May 16, 2022
cortinico
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just added a minor comment you forgot to add, but we can merge this 👍
Uh oh!
There was an error while loading. Please reload this page.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Kotlin example to docs/new-architecture-library-intr
o