Skip to content

Add Kotlin code for "headless-js-android" documentation - #3125

Merged
cortinico merged 11 commits into
react:mainfrom
rokkoo:docs/headless-js-android
Jun 16, 2022
Merged

Add Kotlin code for "headless-js-android" documentation#3125
cortinico merged 11 commits into
react:mainfrom
rokkoo:docs/headless-js-android

Conversation

@rokkoo

Copy link
Copy Markdown
Contributor
3018

@facebook-github-bot

Copy link
Copy Markdown

Hi @rokkoo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@rokkoo

Copy link
Copy Markdown
ContributorAuthor

@cortinico@mdvacca

@netlify

netlifyBot commented May 19, 2022

Copy link
Copy Markdown

Deploy Preview for react-native ready!

NameLink
🔨 Latest commit8727398
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62aaf509eee6c7000804a26b
😎 Deploy Previewhttps://deploy-preview-3125--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this over 👍 Left several comments that needs to be addressed before we can merge this

Comment threaddocs/headless-js-android.md Outdated
Comment threaddocs/headless-js-android.md Outdated
Comment threaddocs/headless-js-android.md Outdated
Comment threaddocs/headless-js-android.md Outdated
Comment threaddocs/headless-js-android.md
Comment threadwebsite/versioned_docs/version-0.68/headless-js-android.md Outdated
Comment threadwebsite/versioned_docs/version-0.68/headless-js-android.md
Comment threadwebsite/versioned_docs/version-0.68/headless-js-android.md
Comment threadwebsite/versioned_docs/version-0.68/headless-js-android.md Outdated
Comment threadwebsite/versioned_docs/version-0.68/headless-js-android.md Outdated
@cortinico

Copy link
Copy Markdown
Contributor

Let me know if you need further support @rokkoo

@rokkoo

Copy link
Copy Markdown
ContributorAuthor

Let me know if you need further support @rokkoo

Thanks @cortinico for the review!

@cortinicocortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another pass @rokkoo
Left a couple of comments but we should be able to merge after this 👍

Comment threaddocs/headless-js-android.md Outdated
Comment threaddocs/headless-js-android.md Outdated
Comment threadwebsite/versioned_docs/version-0.68/headless-js-android.md Outdated
@rokkoo

Copy link
Copy Markdown
ContributorAuthor

Thanks @cortinico!

@cortinico
cortinico merged commit 7d3fd88 into react:mainJun 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rokkoo@facebook-github-bot@cortinico