[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226

Open
fabOnReact wants to merge 5 commits into
react:mainfrom
fabOnReact:accessible-prop
Open

[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom
fabOnReact:accessible-prop

Conversation

@fabOnReact

@fabOnReactfabOnReact commented Jul 27, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver

Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
It's definitely worth clarifying this behavior in the documentation

react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)

On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.

Google on the other hand, has made things quite a bit more complicated.

On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.

fixesreact/react-native#30851

importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images

Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"

https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)

sourcecode of the example

classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}

edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"

2022-07-22.15-47-18.mp4

fixesreact/react-native#30850 (comment)

@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact mentioned this pull request Jul 27, 2022
Closed
@netlify

netlifyBot commented Jul 27, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fabOnReactfabOnReact changed the title screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact changed the title [documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact changed the title [Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact marked this pull request as ready for review August 3, 2022 04:58
@fabOnReactfabOnReact changed the title [Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact mentioned this pull request Nov 21, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues. Android: Blocking elements from being focused

2 participants

@fabOnReact@facebook-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226
Open
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Open
[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Conversation
@fabOnReact
@fabOnReactfabOnReact
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
fixesreact/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)
sourcecode of the example
classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixesreact/react-native#30850 (comment)
@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact
mentioned this pull request
Jul 27, 2022

Closed

@netlify
netlifyBot
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for react-native ready!
NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
 Toggle QR Code... 

QR Code

Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.
@fabOnReactfabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact
marked this pull request as ready for review
August 3, 2022 04:58
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact
mentioned this pull request
Nov 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues.

Android: Blocking elements from being focused


2 participants

@fabOnReact@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226
Open
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Open
[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Conversation
@fabOnReact
@fabOnReactfabOnReact
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
fixesreact/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)
sourcecode of the example
classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixesreact/react-native#30850 (comment)
@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact
mentioned this pull request
Jul 27, 2022

Closed

@netlify
netlifyBot
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for react-native ready!
NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
 Toggle QR Code... 

QR Code

Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.
@fabOnReactfabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact
marked this pull request as ready for review
August 3, 2022 04:58
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact
mentioned this pull request
Nov 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues.

Android: Blocking elements from being focused


2 participants

@fabOnReact@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226
Open
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Open
[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Conversation
@fabOnReact
@fabOnReactfabOnReact
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
fixesreact/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)
sourcecode of the example
classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixesreact/react-native#30850 (comment)
@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact
mentioned this pull request
Jul 27, 2022

Closed

@netlify
netlifyBot
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for react-native ready!
NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
 Toggle QR Code... 

QR Code

Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.
@fabOnReactfabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact
marked this pull request as ready for review
August 3, 2022 04:58
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact
mentioned this pull request
Nov 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues.

Android: Blocking elements from being focused


2 participants

@fabOnReact@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226
Open
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Open
[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Conversation
@fabOnReact
@fabOnReactfabOnReact
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
fixesreact/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)
sourcecode of the example
classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixesreact/react-native#30850 (comment)
@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact
mentioned this pull request
Jul 27, 2022

Closed

@netlify
netlifyBot
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for react-native ready!
NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
 Toggle QR Code... 

QR Code

Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.
@fabOnReactfabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact
marked this pull request as ready for review
August 3, 2022 04:58
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact
mentioned this pull request
Nov 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues.

Android: Blocking elements from being focused


2 participants

@fabOnReact@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226
Open
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Open
[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Conversation
@fabOnReact
@fabOnReactfabOnReact
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
fixesreact/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)
sourcecode of the example
classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixesreact/react-native#30850 (comment)
@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact
mentioned this pull request
Jul 27, 2022

Closed

@netlify
netlifyBot
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for react-native ready!
NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
 Toggle QR Code... 

QR Code

Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.
@fabOnReactfabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact
marked this pull request as ready for review
August 3, 2022 04:58
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact
mentioned this pull request
Nov 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues.

Android: Blocking elements from being focused


2 participants

@fabOnReact@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226
Open
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Open
[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Conversation
@fabOnReact
@fabOnReactfabOnReact
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
fixesreact/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)
sourcecode of the example
classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixesreact/react-native#30850 (comment)
@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact
mentioned this pull request
Jul 27, 2022

Closed

@netlify
netlifyBot
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for react-native ready!
NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
 Toggle QR Code... 

QR Code

Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.
@fabOnReactfabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact
marked this pull request as ready for review
August 3, 2022 04:58
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact
mentioned this pull request
Nov 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues.

Android: Blocking elements from being focused


2 participants

@fabOnReact@facebook-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[Documentation] updating documentation for accessible and accessibilityRole="link" prop - #3226
Open
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Open
[Documentation] updating documentation for accessible and accessibilityRole="link" prop#3226
fabOnReact wants to merge 5 commits into
react:mainfrom 
fabOnReact:accessible-prop
Conversation
@fabOnReact
@fabOnReactfabOnReact
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver
Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).

It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
Google on the other hand, has made things quite a bit more complicated.
On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
fixesreact/react-native#30851
importantForAccessibility="no" does not allow screenreader focus on nested Text Components with accessibilityRole="link" or inline Images
Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78
https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YES
react/react-native#30375 (comment)
sourcecode of the example
classAccessibilityExampleextendsReact.Component<{}>{render(): React.Node{consturi='https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';return(<View><RNTesterBlocktitle="TextView without label"><TextimportantForAccessibility="no"accessible={true}>
This is a Text with an Image as nested Child and a Link.
<TextaccessibilityRole="link">
This is a link
</Text><Imageaccessible={true}focusable={true}importantForAccessibility="yes"accessibilityLabel="image accessibilityLabel"source={{uri}}style={{height: 400,width: 200}}/></Text></RNTesterBlock></View>);}}
edited.copy.mp4
Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"
2022-07-22.15-47-18.mp4
fixesreact/react-native#30850 (comment)
@fabOnReact
screenreader difference in behaviour between TalkBack and VoiceOver
311224e
>Sometimes this will group's descendants that are also marked as accessible together into one focusable element (e.g. accessible with accessible descendants), and sometimes it does not (e.g. accessible with accessible descendants).
>It's definitely worth clarifying this behavior in the documentation
react/react-native#30851 (comment)react/react-native#30851 (comment)react/react-native#30851 (comment)
>On iOS the default behavior (and really, the only reasonably possible behavior), would be that the outer view is focusable, and must be given an accessibilityLabel to describe it. No accessible element can have accessible descendants, and all accessible elements must have an accessibility label. Apple has has this very straightforward, and easy to understand for developers.
>Google on the other hand, has made things quite a bit more complicated.
>On Android, the default behavior in this situation would be that all three views (the outer View and the inner two Text views) would attempt to become focusable (assume that the accessible prop maps to Androids focusable view property), but in this case the outer view would actually need some sort of label to be provided, as it has no content that it could announce. If no label was given, the outer view would become unfocusable and only the inner views would end up being focusable, which is exactly what you are seeing happen with the "Nested Text Views" example. If a label was given (and this label was mapped to the contentDescription property), then all three views would become focusable.
- [x] [prepare documentation PR clarifying differences between iOS and Android](react/react-native#30851 (comment)) for scenarios [accessible parent view and one not accessible child](react/react-native#30851 (comment)) and [parent view with accessibilityLabel does not over-ride children with onPress handler](react/react-native#30851 (comment))
- [ ] iOS documentation for [Nested Text is not accessible](react/react-native#30851 (comment))
@fabOnReactfabOnReact
mentioned this pull request
Jul 27, 2022

Closed

@netlify
netlifyBot
commented
Jul 27, 2022•

edited

Loading

Copy link


Copy Markdown

✅ Deploy Preview for react-native ready!
NameLink
🔨 Latest commit62a4b13
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native/deploys/62e9ffad2e17900008b9bddd
😎 Deploy Previewhttps://deploy-preview-3226--react-native.netlify.app
📱 Preview on mobile
 Toggle QR Code... 

QR Code

Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site settings.
@fabOnReactfabOnReact
changed the title
screenreader difference in behaviour between TalkBack and VoiceOver[documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour between TalkBack and VoiceOverJul 27, 2022
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour between TalkBack and VoiceOver[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOverJul 27, 2022
@fabOnReact
importantForAccessibility="no" does not allow screenreader focus on n…
5e5c0e1
…ested Text Components with accessibilityRole="link" or inline Images
react/react-native#30850 (comment)
<details><summary>Nested Test with accessibilityRole="link" is accessible when parent sets importantForAccessibility="yes"</summary>
<p>
https://github.com/facebook/react-native/pull/33215/files#diff-37199b6b562523b453547e7fb56c95fd9aed5dc01fee3f6bdd50e97297ff8e7fR78https://developer.android.com/reference/android/view/View#IMPORTANT_FOR_ACCESSIBILITY_YESreact/react-native#30375 (comment)
<details><summary>sourcecode of the example</summary>
<p>
```javascript
class AccessibilityExample extends React.Component<{}> {
render(): React.Node {
const uri =
'https://portfoliofabrizio.s3.eu-central-1.amazonaws.com/videos/surfcheck-poster.png';
return (
<View>
<RNTesterBlock title="TextView without label">
<Text importantForAccessibility="no" accessible={true}>
This is a Text with an Image as nested Child and a Link.
<Text
accessibilityRole="link">
This is a link
</Text>
<Image
accessible={true}
focusable={true}
importantForAccessibility="yes"
accessibilityLabel="image accessibilityLabel"
source={{uri}}
style={{height: 400, width: 200}}
/>
</Text>
</RNTesterBlock>
</View>
);
}
}
```
</p>
</details>
<video src="https://user-images.githubusercontent.com/24992535/180412450-071467b1-41ca-4818-b8cc-cbe966b65859.mp4" width="1000" />
</p>
</details>
<details><summary>Nested Test with accessibilityRole="link" is **not** accessible when parent sets importantForAccessibility="no"</summary>
<p>
<video src="https://user-images.githubusercontent.com/24992535/180390384-62129561-5d80-417b-8146-15acee128f76.mp4" width="1000" />
</p>
</details>
<details><summary>ExploreByTouchHelper#requestAccessibiltyFocus</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/com/android/internal/widget/ExploreByTouchHelper.java#L595
```java
/**
* Attempts to give accessibility focus to a virtual view.
* <p>
* A virtual view will not actually take focus if
* {@link AccessibilityManager#isEnabled()} returns false,
* {@link AccessibilityManager#isTouchExplorationEnabled()} returns false,
* or the view already has accessibility focus.
*
* @PARAM virtualViewId The id of the virtual view on which to place
* accessibility focus.
* @return Whether this virtual view actually took accessibility focus.
*/
private boolean requestAccessibilityFocus(int virtualViewId) {
final AccessibilityManager accessibilityManager =
(AccessibilityManager) mContext.getSystemService(Context.ACCESSIBILITY_SERVICE);
if (!mManager.isEnabled()
|| !accessibilityManager.isTouchExplorationEnabled()) {
return false;
}
// TODO: Check virtual view visibility.
if (!isAccessibilityFocused(virtualViewId)) {
// Clear focus from the previously focused view, if applicable.
if (mFocusedVirtualViewId != INVALID_ID) {
sendEventForVirtualView(mFocusedVirtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED);
}
// Set focus on the new view.
mFocusedVirtualViewId = virtualViewId;
// TODO: Only invalidate virtual view bounds.
mView.invalidate();
sendEventForVirtualView(virtualViewId,
AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
return true;
}
return false;
}
```
</p>
</details>
<details><summary>View#onFocusChanged</summary>
<p>
https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/View.java#L12837
```java
/**
* Called by the view system when the focus state of this view changes.
* When the focus change event is caused by directional navigation, direction
* and previouslyFocusedRect provide insight into where the focus is coming from.
* When overriding, be sure to call up through to the super class so that
* the standard focus handling will occur.
*
* @PARAM gainFocus True if the View has focus; false otherwise.
* @PARAM direction The direction focus has moved when requestFocus()
* is called to give this view focus. Values are
* {@link #FOCUS_UP}, {@link #FOCUS_DOWN}, {@link #FOCUS_LEFT},
* {@link #FOCUS_RIGHT}, {@link #FOCUS_FORWARD}, or {@link #FOCUS_BACKWARD}.
* It may not always apply, in which case use the default.
* @PARAM previouslyFocusedRect The rectangle, in this view's coordinate
* system, of the previously focused view. If applicable, this will be
* passed in as finer grained information about where the focus is coming
* from (in addition to direction). Will be <code>null</code> otherwise.
*/
@callsuper
protected void onFocusChanged(boolean gainFocus, @FocusDirection int direction,
@nullable Rect previouslyFocusedRect) {
if (gainFocus) {
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_FOCUSED);
} else {
notifyViewAccessibilityStateChangedIfNeeded(
AccessibilityEvent.CONTENT_CHANGE_TYPE_UNDEFINED);
}
// Here we check whether we still need the default focus highlight, and switch it on/off.
switchDefaultFocusHighlight();
if (!gainFocus) {
if (isPressed()) {
setPressed(false);
}
if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(false /* hasFocus */);
}
onFocusLost();
} else if (hasWindowFocus()) {
notifyFocusChangeToImeFocusController(true /* hasFocus */);
}
invalidate(true);
ListenerInfo li = mListenerInfo;
if (li != null && li.mOnFocusChangeListener != null) {
li.mOnFocusChangeListener.onFocusChange(this, gainFocus);
}
if (mAttachInfo != null) {
mAttachInfo.mKeyDispatchState.reset(this);
}
if (mParent != null) {
mParent.onDescendantUnbufferedRequested();
}
notifyEnterOrExitForAutoFillIfNeeded(gainFocus);
}
```
</p>
</details>
<details><summary>View#findAccessibilityFocusHost</summary>
<p>
```java
/**
* Returns the view within this view's hierarchy that is hosting
* accessibility focus.
*
* @PARAM searchDescendants whether to search for focus in descendant views
* @return the view hosting accessibility focus, or {@code null}
*/
private View findAccessibilityFocusHost(boolean searchDescendants) {
if (isAccessibilityFocusedViewOrHost()) {
return this;
}
if (searchDescendants) {
final ViewRootImpl viewRoot = getViewRootImpl();
if (viewRoot != null) {
final View focusHost = viewRoot.getAccessibilityFocusedHost();
if (focusHost != null && ViewRootImpl.isViewDescendantOf(focusHost, this)) {
return focusHost;
}
}
}
return null;
}
```
</p>
</details>
@fabOnReact
adding doc to Text section
62a4b13
@fabOnReact
fabOnReact
marked this pull request as ready for review
August 3, 2022 04:58
@fabOnReactfabOnReact
changed the title
[Documentation] screenreader difference in behaviour of accessible prop between TalkBack and VoiceOver[Documentation] updating documentation for accessible and accessibilityRole="link" propAug 3, 2022
@fabOnReactfabOnReact
mentioned this pull request
Nov 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Android: "accessible" prop issues.

Android: Blocking elements from being focused


2 participants

@fabOnReact@facebook-github-bot